Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28380 )
Change subject: [WIP] Nvidia Optimus support for ThinkPads ......................................................................
Patch Set 2:
(2 comments)
Good job! I already fixed _ROM a few times... Time to add tests to FWTS.
https://review.coreboot.org/#/c/28380/2/src/mainboard/lenovo/t430/cmos.layou... File src/mainboard/lenovo/t430/cmos.layout:
https://review.coreboot.org/#/c/28380/2/src/mainboard/lenovo/t430/cmos.layou... PS2, Line 131: Graphics Unrelated to optimus as you can use two GPUs even without it. Please add it in a separate commit.
https://review.coreboot.org/#/c/28380/2/src/mainboard/lenovo/t430s/Kconfig File src/mainboard/lenovo/t430s/Kconfig:
https://review.coreboot.org/#/c/28380/2/src/mainboard/lenovo/t430s/Kconfig@2... PS2, Line 26: DRIVERS_LENOVO_HYBRID_GRAPHICS T430s doesn't have hybrid graphics, as there's no mux at the lvds panel. You could add a CMOS option to enable/disable the dGPU instead. Dynamic power switching using Optimus is possible here too ofc.