Attention is currently required from: Martin Roth. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52475 )
Change subject: mb/hp: Add Compal LA-A992P ......................................................................
Patch Set 2:
(17 comments)
File src/mainboard/hp/hp_15_notebook_pc/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117162): https://review.coreboot.org/c/coreboot/+/52475/comment/6d2e5d9b_82e465c6 PS2, Line 15: /* 00 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x40, 0x00, 0x00, 0x00, 0xff, 0x04, 0x00, 0x00, 0x12, 0x01, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117162): https://review.coreboot.org/c/coreboot/+/52475/comment/f8b84629_c647cd2e PS2, Line 16: /* 10 */ 0x01, 0x1b, 0x33, 0x1b, 0x00, 0x00, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x00, 0x04, 0x03, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117162): https://review.coreboot.org/c/coreboot/+/52475/comment/97b2f72e_940420d2 PS2, Line 17: /* 20 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117162): https://review.coreboot.org/c/coreboot/+/52475/comment/779da19a_8ca0d63b PS2, Line 18: /* 30 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117162): https://review.coreboot.org/c/coreboot/+/52475/comment/929bb7c0_400a3104 PS2, Line 19: /* 40 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117162): https://review.coreboot.org/c/coreboot/+/52475/comment/1a1473d8_2f745b0a PS2, Line 20: /* 50 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117162): https://review.coreboot.org/c/coreboot/+/52475/comment/28cea5a8_6e4c3daa PS2, Line 21: /* 60 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117162): https://review.coreboot.org/c/coreboot/+/52475/comment/887403c3_0f1e7241 PS2, Line 22: /* 70 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117162): https://review.coreboot.org/c/coreboot/+/52475/comment/1aa646a2_67e504d6 PS2, Line 23: /* 80 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117162): https://review.coreboot.org/c/coreboot/+/52475/comment/426b8336_e5c2ebd1 PS2, Line 24: /* 90 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117162): https://review.coreboot.org/c/coreboot/+/52475/comment/caf3f15e_d4a9784c PS2, Line 25: /* a0 */ 0x00, 0x04, 0x00, 0x86, 0xc1, 0x00, 0x00, 0x61, 0x63, 0x00, 0x00, 0x08, 0x64, 0x1a, 0x00, 0xf0, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117162): https://review.coreboot.org/c/coreboot/+/52475/comment/873c4663_7c94deb6 PS2, Line 26: /* b0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x09, 0x00, 0x00, 0x32, 0x02, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117162): https://review.coreboot.org/c/coreboot/+/52475/comment/051163d0_d098d731 PS2, Line 27: /* c0 */ 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117162): https://review.coreboot.org/c/coreboot/+/52475/comment/1134e77c_c9cfa37f PS2, Line 28: /* d0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117162): https://review.coreboot.org/c/coreboot/+/52475/comment/a778c1b5_59a8471f PS2, Line 29: /* e0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117162): https://review.coreboot.org/c/coreboot/+/52475/comment/9badc55c_33cf85a1 PS2, Line 30: /* f0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117162): https://review.coreboot.org/c/coreboot/+/52475/comment/88479578_9e94c02d PS2, Line 35: ec_write (i, dmp[i]); space prohibited between function name and open parenthesis '('
-
build bot (Jenkins) (Code Review)