Attention is currently required from: Felix Singer, Jamie Ryu, Subrata Banik, Wonkyu Kim, Ethan Tsao, Ravishankar Sarawadi, Paul Menzel, Angel Pons, Raj Astekar. Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62772 )
Change subject: soc/intel/mtl: Do initial Meteor Lake SoC commit till bootblock ......................................................................
Patch Set 12:
(6 comments)
File src/soc/intel/meteorlake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/62772/comment/0c804761_63672ca2 PS10, Line 20: bootblock_pch_early_init(); : ioe_p2sb_enable_bar(); : fast_spi_cache_bios_region(); : pch_early_iorange_init();
can you please try to logically separate these functions as in […]
Done
File src/soc/intel/meteorlake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/62772/comment/6ea44008_e7f93395 PS11, Line 24: /* Programming TCO_BASE_ADDRESS and TCO Timer Halt */ : tco_configure();
shouldn't TCO also should land into `bootblock_soc_die_init`?
Done
File src/soc/intel/meteorlake/bootblock/ioe_die.c:
https://review.coreboot.org/c/coreboot/+/62772/comment/df8eae19_ec69cfe5 PS11, Line 10:
please one newline ?
Done
File src/soc/intel/meteorlake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/62772/comment/bf6ead2a_c8ad7985 PS11, Line 30: MeteorLake
can we maintain the name symmetry between either MeteorLake or Meteorlake alone and not the mix?
Done
File src/soc/intel/meteorlake/bootblock/soc_die.c:
https://review.coreboot.org/c/coreboot/+/62772/comment/a048e5a5_3a2de80e PS11, Line 57: bootblock_systemagent_early_init(); : fast_spi_cache_bios_region(); : soc_die_early_iorange_init(); : if (CONFIG(INTEL_LPSS_UART_FOR_CONSOLE)) : uart_bootblock_init();
tab please?
Done
https://review.coreboot.org/c/coreboot/+/62772/comment/52a8a004_d439d344 PS11, Line 74: Enabling PWRM Base for accessing
Enabling SoC PMC PWRM Base for accessing
Done