Attention is currently required from: Anilkumar N, Kangheui Won, Maulik V Vaghela, Tim Wawrzynczak, Rizwan Qureshi, Subrata Banik, Sridhar Siricilla.
Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59937 )
Change subject: mb/intel/adlrvp: Configure GPIOs for Alder Lake-N
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/intel/adlrvp/gpio_n.c:
https://review.coreboot.org/c/coreboot/+/59937/comment/996f1745_c484c916
PS5, Line 52: /*TCP1_DISP_AUX_P_BIAS_GPIO*/
: PAD_CFG_GPO(GPP_E20, 1, PLTRST),
: /*TCP1_DISP_AUX_N_BIAS_GPIO*/
: PAD_CFG_GPO(GPP_E21, 0, PLTRST),
: /*TCP0_DISP_AUX_P_BIAS_GPIO*/
: PAD_CFG_GPO(GPP_E22, 0, PLTRST),
: /*TCP0_DISP_AUX_N_BIAS_GPIO*/
: PAD_CFG_GPO(GPP_E23, 1, PLTRST),
I am guessing here from the pad names, but should these be NF6 for AUX BIAS functionality?
These are GPIO pins used for providing BIAS functionality to the AUX lines. We will configure them based on the orientation of the display device plugged on Type-C.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59937
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c0ca52d0cc73acfd8503007d5f3d2ad9a48f8ca
Gerrit-Change-Number: 59937
Gerrit-PatchSet: 6
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Anilkumar N
anilkumar.n@intel.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Anilkumar N
anilkumar.n@intel.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Thu, 16 Dec 2021 06:53:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment