Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Shon Wang, Subrata Banik.
Eric Lai has posted comments on this change by Shon Wang. ( https://review.coreboot.org/c/coreboot/+/83380?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brask/var/bujia: remove DPTF fan control
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83380/comment/67c85d95_af1325bc?usp... :
PS2, Line 9: fan control is assign to EC handle now.
: remove relate setting on coreboot.
:
please reformat the comment.
https://www.coreboot.org/Git#Commit_messages
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83380?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iff0776ce3db6f27e250162357abb3c7e9b1a0dc3
Gerrit-Change-Number: 83380
Gerrit-PatchSet: 2
Gerrit-Owner: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Fri, 12 Jul 2024 05:03:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes