Attention is currently required from: Furquan Shaikh, Sridhar Siricilla, Bernardo Perez Priego, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58158 )
Change subject: soc/intel/common/cse: Split CSE metadata into two CBFS files ......................................................................
Patch Set 9:
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/58158/comment/26e484b1_2f1c18df PS9, Line 598: if (!read_ver_field(version_str, &ptr, size, &cbfs_rw_version.major)) : return CSE_UPDATE_METADATA_ERROR; : if (!read_ver_field(version_str, &ptr, size, &cbfs_rw_version.minor)) : return CSE_UPDATE_METADATA_ERROR; : if (!read_ver_field(version_str, &ptr, size, &cbfs_rw_version.hotfix)) : return CSE_UPDATE_METADATA_ERROR; : if (!read_ver_field(version_str, &ptr, size, &cbfs_rw_version.build)) : return CSE_UPDATE_METADATA_ERROR; I think version_str still needs to be unmapped here on the errors?, maybe reorganizing it would work better
``` if (!read_ver_field(version_str, &ptr, size, &cbfs_rw_version.major) || !read_ver_field(version_str, &ptr, size, &cbfs_rw_version.minor) || !read_ver_field(version_str, &ptr, size, &cbfs_rw_version.hotfix) || !read_ver_field(version_str, &ptr, size, &cbfs_rw_version.build)) { cbfs_unmap(version_str); return CSE_UPDATE_METADATA_ERROR; } ```