John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39367 )
Change subject: src/soc/tigerlake: add S0ix support fsp_params
......................................................................
Patch Set 3:
Patch Set 3:
Ia this still needed?
With default FSP setting for PmcLpmS0ixSubStateEnableM, PchFivrVccinAuxLowToHighCurModeVolTranTime, PchFivrVccinAuxRetToHighCurModeVolTranTime and PchFivrVccinAuxOffToHighCurModeVolTranTime, S0ix had been validated across Volteer and TGLRVP. It is not needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39367
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf29865e80311d6ef52ea0ff2a722f8d4e845dd7
Gerrit-Change-Number: 39367
Gerrit-PatchSet: 3
Gerrit-Owner: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 10 Sep 2020 20:25:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment