Attention is currently required from: Arthur Heymans, Felix Singer, Kyösti Mälkki, Lance Zhao.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76008?usp=email )
Change subject: acpi/acpi.c: Split of ACPI table generation into separate files
......................................................................
Patch Set 1:
(2 comments)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/76008/comment/c67facd7_046a0898 :
PS1, Line 213: #if ENV_X86
Easy enough to move later.
seems reasonable to have arch-specific dirs in ACPI; for example DMAR is Intel specific
File src/acpi/acpi_dmar.c:
PS1:
not related to this patch, but while we're talking about DMAR, is there any interest in switching to VIOT instead? It's the non-vendor-specific replacement for all of these vendor-specific IOMMU tables (https://lwn.net/Articles/859291/)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76008?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5083b26c0d4cc6764b4e3cb0ff586797cae7e3af
Gerrit-Change-Number: 76008
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sat, 24 Jun 2023 14:32:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment