Attention is currently required from: Sean Rhodes, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58149 )
Change subject: soc/intel/*/me.c: Check more than PCI interface for printing ME info ......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/alderlake/me.c:
https://review.coreboot.org/c/coreboot/+/58149/comment/2d4cf973_eadd77c6 PS1, Line 103: !cse_is_hfs1_cws_normal() || : !cse_is_hfs1_com_normal() || : !cse_is_hfs1_com_soft_temp_disable()) : return;
Frankly speaking, I *always* want these printed in my logs. […]
Oh sorry I misunderstood.
So IIUC you want to bypass the `!cse_dev->enabled` check from `is_cse_enabled()` here?
I think it might be OK to change the condition from ``` if (!is_cse_enabled()) return; ```
to something more like:
``` if (pci_read_config16(PCH_DEV_CSE, PCI_VENDOR_ID) == 0xFFFF) { printk(BIOS_WARN, "CSE: device is hidden\n"); return false; } ```
which is obviously the condition where the PCI config space reads won't return anything useful anyway.
and then this is checking *only* the PCI interface, instead of the devicetree device status.