Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39870 )
Change subject: mb/ocp/tiogapass: Add missing spaces around operators ......................................................................
mb/ocp/tiogapass: Add missing spaces around operators
Change-Id: I8930e96e5f2c45b8658dc4dfe1ab57d573e7b26f Fixes: b75bcc978a ("mb/ocp/tiogapass: Properly configure early serial output") Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/mainboard/ocp/tiogapass/bootblock.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/39870/1
diff --git a/src/mainboard/ocp/tiogapass/bootblock.c b/src/mainboard/ocp/tiogapass/bootblock.c index d9a86e9..d507422 100644 --- a/src/mainboard/ocp/tiogapass/bootblock.c +++ b/src/mainboard/ocp/tiogapass/bootblock.c @@ -29,7 +29,7 @@
/* Enable com1 (0x3f8), com2 (02f8) and superio (0x2e) */ pci_mmio_write_config32(PCH_DEV_LPC, 0x80, - (1<<28) | (1<<16) | (1<<17) | (0 << 0) | (1 << 4)); + (1 << 28) | (1 << 16) | (1 << 17) | (0 << 0) | (1 << 4)); }
static uint8_t com_to_ast_sio(uint8_t com)
Paul Menzel has removed build bot (Jenkins) from this change. ( https://review.coreboot.org/c/coreboot/+/39870 )
Change subject: mb/ocp/tiogapass: Add missing spaces around operators ......................................................................
Removed reviewer build bot (Jenkins).
Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39870 )
Change subject: mb/ocp/tiogapass: Add missing spaces around operators ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39870 )
Change subject: mb/ocp/tiogapass: Add missing spaces around operators ......................................................................
Patch Set 2: Code-Review+1
I think it needs a rebase
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39870 )
Change subject: mb/ocp/tiogapass: Add missing spaces around operators ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39870 )
Change subject: mb/ocp/tiogapass: Add missing spaces around operators ......................................................................
mb/ocp/tiogapass: Add missing spaces around operators
Change-Id: I8930e96e5f2c45b8658dc4dfe1ab57d573e7b26f Fixes: b75bcc978a ("mb/ocp/tiogapass: Properly configure early serial output") Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/39870 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Andrey Petrov andrey.petrov@gmail.com --- M src/mainboard/ocp/tiogapass/bootblock.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Andrey Petrov: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/ocp/tiogapass/bootblock.c b/src/mainboard/ocp/tiogapass/bootblock.c index d9a86e9..d507422 100644 --- a/src/mainboard/ocp/tiogapass/bootblock.c +++ b/src/mainboard/ocp/tiogapass/bootblock.c @@ -29,7 +29,7 @@
/* Enable com1 (0x3f8), com2 (02f8) and superio (0x2e) */ pci_mmio_write_config32(PCH_DEV_LPC, 0x80, - (1<<28) | (1<<16) | (1<<17) | (0 << 0) | (1 << 4)); + (1 << 28) | (1 << 16) | (1 << 17) | (0 << 0) | (1 << 4)); }
static uint8_t com_to_ast_sio(uint8_t com)
-
Andrey Petrov (Code Review) -
Angel Pons (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)