Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83989?usp=email )
Change subject: soc/mediatek: Move SNFC pad_func into MediaTek common directory ......................................................................
Patch Set 4:
(4 comments)
File src/soc/mediatek/common/flash_controller.c:
https://review.coreboot.org/c/coreboot/+/83989/comment/8338281e_5d2fef87?usp... : PS4, Line 236: __func__, strength, pad_func->gpio.id);
Change the return type to int and return -1 here. […]
Done
File src/soc/mediatek/common/include/soc/flash_controller_common.h:
https://review.coreboot.org/c/coreboot/+/83989/comment/a7615b92_3e6490f1?usp... : PS4, Line 9: #include <gpio.h>
sort
Done
https://review.coreboot.org/c/coreboot/+/83989/comment/60c37949_208fcfd0?usp... : PS4, Line 79: /* pad func */
Remove comment as it explains nothing.
Done
https://review.coreboot.org/c/coreboot/+/83989/comment/d3f4ddbe_9d31663d?usp... : PS4, Line 80: struct pad_func { : gpio_t gpio; : u8 func; : enum pull_select select; : };
Maybe we can rename it to something like `snfc_pad_func` or `mtk_snfc_pad_func`. […]
Done