Attention is currently required from: Felix Singer, Julius Werner, Name of user not set #1005536.
Nico Huber has posted comments on this change by Name of user not set #1005536. ( https://review.coreboot.org/c/coreboot/+/83378?usp=email )
Change subject: libpayload/commonlib: warning fixes
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
We found the problem why the coreinfo build failed: […]
We want to go ahead and enable more of the `-Wextra` warnings anyway.
This patch is still valuable. It should probably be split into smaller
commits, though. And we should decide which warnings we want. For
instance `-Wunused-parameters` is *not* one of my favorites.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83378?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I23462a9c920a57e9cdf6a98174f0bea1a8b1ed19
Gerrit-Change-Number: 83378
Gerrit-PatchSet: 2
Gerrit-Owner: Name of user not set #1005536
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Name of user not set #1005536
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 08 Jul 2024 20:40:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Name of user not set #1005536