Change in coreboot[master]: nb/i945: Don't hardcode 'integrated_graphics' to 1

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

12 Apr 2020 12 Apr '20

6:52 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40331 )

Change subject: nb/i945: Don't hardcode 'integrated_graphics' to 1 ......................................................................

nb/i945: Don't hardcode 'integrated_graphics' to 1

Read GGC register to test if IGD VGA is disabled or not.

Change-Id: I864904ee726e008914170fa9c6f3a24a58242ae6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/raminit.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/40331/1

diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c index f26fac6..730b56a 100644 --- a/src/northbridge/intel/i945/raminit.c +++ b/src/northbridge/intel/i945/raminit.c @@ -2146,7 +2146,7 @@ u8 reg8; u16 reg16; u32 reg32; - int integrated_graphics = 1; + int integrated_graphics = pci_read_config16(pcidev_on_root(0, 0), GGC) & 2; int i;

reg32 = MCHBAR32(C0DRT2);

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

HAOUAS Elyes (Code Review)

12 Apr 12 Apr

8:04 p.m.

Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40331

to look at the new patch set (#2).

Change subject: nb/i945: Don't hardcode 'integrated_graphics' to 1 ......................................................................

nb/i945: Don't hardcode 'integrated_graphics' to 1

Read GGC register to test if IGD VGA is disabled or not.

Change-Id: I864904ee726e008914170fa9c6f3a24a58242ae6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/raminit.c 1 file changed, 2 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/40331/2

HAOUAS Elyes (Code Review)

13 Apr 13 Apr

5:46 a.m.

Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40331

to look at the new patch set (#3).

Change subject: nb/i945: Don't hardcode 'integrated_graphics' to 1 ......................................................................

nb/i945: Don't hardcode 'integrated_graphics' to 1

Read GGC register to test if IGD VGA is disabled or not.

Change-Id: I864904ee726e008914170fa9c6f3a24a58242ae6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/raminit.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/40331/3

Paul Menzel (Code Review)

16 Apr 16 Apr

12:25 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40331 )

Change subject: nb/i945: Don't hardcode 'integrated_graphics' to 1 ......................................................................

Patch Set 7:

(3 comments)

https://review.coreboot.org/c/coreboot/+/40331/7/src/northbridge/intel/i945/... File src/northbridge/intel/i945/raminit.c:

https://review.coreboot.org/c/coreboot/+/40331/7/src/northbridge/intel/i945/... PS7, Line 2149: PCI_DEV(0, 0x00, 0) Only `0x0`? Is there a macro for the expression?

https://review.coreboot.org/c/coreboot/+/40331/7/src/northbridge/intel/i945/... PS7, Line 2305: #ifdef C2_SELF_REFRESH_DISABLE Afterward set `integrated_graphics` down here, so it’s closer to the usage?

NB: That macro does not exist (commit 71a3d96bc (* drop ich7 include)).

https://review.coreboot.org/c/coreboot/+/40331/7/src/northbridge/intel/i945/... PS7, Line 2308: printk(BIOS_DEBUG, "C2 self-refresh with IGD\n"); Isn’t that the disabled branch of `ifdef`?

-- To view, visit https://review.coreboot.org/c/coreboot/+/40331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I864904ee726e008914170fa9c6f3a24a58242ae6 Gerrit-Change-Number: 40331 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 16 Apr 2020 12:25:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

12:47 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40331 )

Change subject: nb/i945: Don't hardcode 'integrated_graphics' to 1 ......................................................................

Patch Set 7:

(3 comments)

https://review.coreboot.org/c/coreboot/+/40331/7/src/northbridge/intel/i945/... File src/northbridge/intel/i945/raminit.c:

https://review.coreboot.org/c/coreboot/+/40331/7/src/northbridge/intel/i945/... PS7, Line 2149: PCI_DEV(0, 0x00, 0)

...

Only `0x0`? Is there a macro for the expression?

I don't think so for i945

git grep 'PCI_DEV(0, 0x00, 0)' |grep i945

https://review.coreboot.org/c/coreboot/+/40331/7/src/northbridge/intel/i945/... PS7, Line 2305: #ifdef C2_SELF_REFRESH_DISABLE

...

Afterward set `integrated_graphics` down here, so it’s closer to the usage? […]

Ack

https://review.coreboot.org/c/coreboot/+/40331/7/src/northbridge/intel/i945/... PS7, Line 2308: printk(BIOS_DEBUG, "C2 self-refresh with IGD\n");

...

Isn’t that the disabled branch of `ifdef`?

yes, as C2_SELF_REFRESH_DISABLE = 0

-- To view, visit https://review.coreboot.org/c/coreboot/+/40331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I864904ee726e008914170fa9c6f3a24a58242ae6 Gerrit-Change-Number: 40331 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 16 Apr 2020 12:47:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

12:49 p.m.

Hello build bot (Jenkins), Arthur Heymans, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40331

to look at the new patch set (#8).

Change subject: nb/i945: Don't hardcode 'integrated_graphics' to 1 ......................................................................

nb/i945: Don't hardcode 'integrated_graphics' to 1

Read GGC register to test if IGD VGA is disabled or not.

Change-Id: I864904ee726e008914170fa9c6f3a24a58242ae6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/raminit.c 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/40331/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/40331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I864904ee726e008914170fa9c6f3a24a58242ae6 Gerrit-Change-Number: 40331 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

2:52 p.m.

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40331 )

Change subject: nb/i945: Don't hardcode 'integrated_graphics' to 1 ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/40331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I864904ee726e008914170fa9c6f3a24a58242ae6 Gerrit-Change-Number: 40331 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1627

days inactive

1631

days old

coreboot-gerrit@coreboot.org

6 comments

2 participants

tags (0)

participants (2)

HAOUAS Elyes (Code Review)
Paul Menzel (Code Review)