HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43712 )
Change subject: sb/amd/agesa/hudson/hudson.h: Add include <types.h> ......................................................................
sb/amd/agesa/hudson/hudson.h: Add include <types.h>
BIT(x) needs <types.h>.
Change-Id: I709b98e57275a5666a9627af9f57a7d47c855c88 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/amd/agesa/hudson/hudson.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/43712/1
diff --git a/src/southbridge/amd/agesa/hudson/hudson.h b/src/southbridge/amd/agesa/hudson/hudson.h index 9b6663a..eeb60ca 100644 --- a/src/southbridge/amd/agesa/hudson/hudson.h +++ b/src/southbridge/amd/agesa/hudson/hudson.h @@ -4,6 +4,7 @@ #define HUDSON_H
#include <device/device.h> +#include <types.h>
/* Power management index/data registers */ #define BIOSRAM_INDEX 0xcd4
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43712 )
Change subject: sb/amd/agesa/hudson/hudson.h: Add include <types.h> ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43712 )
Change subject: sb/amd/agesa/hudson/hudson.h: Add include <types.h> ......................................................................
sb/amd/agesa/hudson/hudson.h: Add include <types.h>
BIT(x) needs <types.h>.
Change-Id: I709b98e57275a5666a9627af9f57a7d47c855c88 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/43712 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/amd/agesa/hudson/hudson.h 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/southbridge/amd/agesa/hudson/hudson.h b/src/southbridge/amd/agesa/hudson/hudson.h index 9b6663a..eeb60ca 100644 --- a/src/southbridge/amd/agesa/hudson/hudson.h +++ b/src/southbridge/amd/agesa/hudson/hudson.h @@ -4,6 +4,7 @@ #define HUDSON_H
#include <device/device.h> +#include <types.h>
/* Power management index/data registers */ #define BIOSRAM_INDEX 0xcd4
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)