HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45556 )
Change subject: mb/getac/p470/acpi: Convert 'gpe.asl' to ASL 2.0 syntax ......................................................................
mb/getac/p470/acpi: Convert 'gpe.asl' to ASL 2.0 syntax
Change-Id: I9f5a89946888be3ed033c2ee079f171a23404e90 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/getac/p470/acpi/gpe.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/45556/1
diff --git a/src/mainboard/getac/p470/acpi/gpe.asl b/src/mainboard/getac/p470/acpi/gpe.asl index e72b980..b9e4056 100644 --- a/src/mainboard/getac/p470/acpi/gpe.asl +++ b/src/mainboard/getac/p470/acpi/gpe.asl @@ -15,7 +15,7 @@ // Software GPE Method (_L02, 0) { - Store (0, GPEC) + GPEC = 0 }
// USB1 @@ -42,7 +42,7 @@ // SMBus (Reserved!) Method (_L07, 0) { - // Store (0x20, _SB.PCI0.SBUS.HSTS) + // _SB.PCI0.SBUS.HSTS = 0x20 }
// COM1/COM2 (RI)
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45556 )
Change subject: mb/getac/p470/acpi: Convert 'gpe.asl' to ASL 2.0 syntax ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45556 )
Change subject: mb/getac/p470/acpi: Convert 'gpe.asl' to ASL 2.0 syntax ......................................................................
mb/getac/p470/acpi: Convert 'gpe.asl' to ASL 2.0 syntax
Change-Id: I9f5a89946888be3ed033c2ee079f171a23404e90 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/45556 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/getac/p470/acpi/gpe.asl 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/getac/p470/acpi/gpe.asl b/src/mainboard/getac/p470/acpi/gpe.asl index e72b980..b9e4056 100644 --- a/src/mainboard/getac/p470/acpi/gpe.asl +++ b/src/mainboard/getac/p470/acpi/gpe.asl @@ -15,7 +15,7 @@ // Software GPE Method (_L02, 0) { - Store (0, GPEC) + GPEC = 0 }
// USB1 @@ -42,7 +42,7 @@ // SMBus (Reserved!) Method (_L07, 0) { - // Store (0x20, _SB.PCI0.SBUS.HSTS) + // _SB.PCI0.SBUS.HSTS = 0x20 }
// COM1/COM2 (RI)
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)
-
Tim Wawrzynczak (Code Review)