Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46786 )
Change subject: soc/intel/broadwell/acpi: Rename `systemagent.asl` ......................................................................
soc/intel/broadwell/acpi: Rename `systemagent.asl`
Rename it to `hostbridge.asl`, which is what Haswell uses.
Change-Id: I6f97fc5c9459fe6b66dcfcf51900c751beda0ebe Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/auron/dsdt.asl M src/mainboard/google/jecht/dsdt.asl M src/mainboard/intel/wtm2/dsdt.asl M src/mainboard/purism/librem_bdw/dsdt.asl R src/soc/intel/broadwell/acpi/hostbridge.asl 5 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/46786/1
diff --git a/src/mainboard/google/auron/dsdt.asl b/src/mainboard/google/auron/dsdt.asl index a61a669..9da89ef 100644 --- a/src/mainboard/google/auron/dsdt.asl +++ b/src/mainboard/google/auron/dsdt.asl @@ -24,7 +24,7 @@ Scope (_SB) { Device (PCI0) { - #include <soc/intel/broadwell/acpi/systemagent.asl> + #include <soc/intel/broadwell/acpi/hostbridge.asl> #include <soc/intel/broadwell/pch/acpi/pch.asl> #include <drivers/intel/gma/acpi/default_brightness_levels.asl> } diff --git a/src/mainboard/google/jecht/dsdt.asl b/src/mainboard/google/jecht/dsdt.asl index 6af99b4..05754ca 100644 --- a/src/mainboard/google/jecht/dsdt.asl +++ b/src/mainboard/google/jecht/dsdt.asl @@ -25,7 +25,7 @@ Scope (_SB) { Device (PCI0) { - #include <soc/intel/broadwell/acpi/systemagent.asl> + #include <soc/intel/broadwell/acpi/hostbridge.asl> #include <soc/intel/broadwell/pch/acpi/pch.asl> } } diff --git a/src/mainboard/intel/wtm2/dsdt.asl b/src/mainboard/intel/wtm2/dsdt.asl index c842e8b..7d58eb6 100644 --- a/src/mainboard/intel/wtm2/dsdt.asl +++ b/src/mainboard/intel/wtm2/dsdt.asl @@ -25,7 +25,7 @@ Scope (_SB) { Device (PCI0) { - #include <soc/intel/broadwell/acpi/systemagent.asl> + #include <soc/intel/broadwell/acpi/hostbridge.asl> #include <soc/intel/broadwell/pch/acpi/pch.asl> } } diff --git a/src/mainboard/purism/librem_bdw/dsdt.asl b/src/mainboard/purism/librem_bdw/dsdt.asl index a4b5bd8..3c0041e 100644 --- a/src/mainboard/purism/librem_bdw/dsdt.asl +++ b/src/mainboard/purism/librem_bdw/dsdt.asl @@ -21,7 +21,7 @@ Scope (_SB) { Device (PCI0) { - #include <soc/intel/broadwell/acpi/systemagent.asl> + #include <soc/intel/broadwell/acpi/hostbridge.asl> #include <soc/intel/broadwell/pch/acpi/pch.asl> } } diff --git a/src/soc/intel/broadwell/acpi/systemagent.asl b/src/soc/intel/broadwell/acpi/hostbridge.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/systemagent.asl rename to src/soc/intel/broadwell/acpi/hostbridge.asl
Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46786
to look at the new patch set (#2).
Change subject: soc/intel/broadwell/acpi: Rename `systemagent.asl` ......................................................................
soc/intel/broadwell/acpi: Rename `systemagent.asl`
Rename it to `hostbridge.asl`, which is what Haswell uses.
Change-Id: I6f97fc5c9459fe6b66dcfcf51900c751beda0ebe Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/auron/dsdt.asl M src/mainboard/google/jecht/dsdt.asl M src/mainboard/intel/wtm2/dsdt.asl M src/mainboard/purism/librem_bdw/dsdt.asl D src/soc/intel/broadwell/acpi/systemagent.asl 5 files changed, 4 insertions(+), 201 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/46786/2
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46786
to look at the new patch set (#3).
Change subject: soc/intel/broadwell/acpi: Rename `systemagent.asl` ......................................................................
soc/intel/broadwell/acpi: Rename `systemagent.asl`
Rename it to `hostbridge.asl`, which is what Haswell uses.
Change-Id: I6f97fc5c9459fe6b66dcfcf51900c751beda0ebe Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/auron/dsdt.asl M src/mainboard/google/jecht/dsdt.asl M src/mainboard/intel/wtm2/dsdt.asl M src/mainboard/purism/librem_bdw/dsdt.asl R src/soc/intel/broadwell/acpi/hostbridge.asl 5 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/46786/3
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46786 )
Change subject: soc/intel/broadwell/acpi: Rename `systemagent.asl` ......................................................................
Patch Set 8:
hm, not sure about this. maybe in haswell it should be renamed to systemagent instead (it's the more common name, isn't it?)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46786 )
Change subject: soc/intel/broadwell/acpi: Rename `systemagent.asl` ......................................................................
Patch Set 8:
Patch Set 8:
hm, not sure about this. maybe in haswell it should be renamed to systemagent instead (it's the more common name, isn't it?)
systemagent is the common name if you look at SoCs, but hostbridge is the norm among older northbridges.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46786 )
Change subject: soc/intel/broadwell/acpi: Rename `systemagent.asl` ......................................................................
Patch Set 8: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46786 )
Change subject: soc/intel/broadwell/acpi: Rename `systemagent.asl` ......................................................................
soc/intel/broadwell/acpi: Rename `systemagent.asl`
Rename it to `hostbridge.asl`, which is what Haswell uses.
Change-Id: I6f97fc5c9459fe6b66dcfcf51900c751beda0ebe Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46786 Reviewed-by: Michael Niewöhner foss@mniewoehner.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/auron/dsdt.asl M src/mainboard/google/jecht/dsdt.asl M src/mainboard/intel/wtm2/dsdt.asl M src/mainboard/purism/librem_bdw/dsdt.asl R src/soc/intel/broadwell/acpi/hostbridge.asl 5 files changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/google/auron/dsdt.asl b/src/mainboard/google/auron/dsdt.asl index a61a669..9da89ef 100644 --- a/src/mainboard/google/auron/dsdt.asl +++ b/src/mainboard/google/auron/dsdt.asl @@ -24,7 +24,7 @@ Scope (_SB) { Device (PCI0) { - #include <soc/intel/broadwell/acpi/systemagent.asl> + #include <soc/intel/broadwell/acpi/hostbridge.asl> #include <soc/intel/broadwell/pch/acpi/pch.asl> #include <drivers/intel/gma/acpi/default_brightness_levels.asl> } diff --git a/src/mainboard/google/jecht/dsdt.asl b/src/mainboard/google/jecht/dsdt.asl index 6af99b4..05754ca 100644 --- a/src/mainboard/google/jecht/dsdt.asl +++ b/src/mainboard/google/jecht/dsdt.asl @@ -25,7 +25,7 @@ Scope (_SB) { Device (PCI0) { - #include <soc/intel/broadwell/acpi/systemagent.asl> + #include <soc/intel/broadwell/acpi/hostbridge.asl> #include <soc/intel/broadwell/pch/acpi/pch.asl> } } diff --git a/src/mainboard/intel/wtm2/dsdt.asl b/src/mainboard/intel/wtm2/dsdt.asl index c842e8b..7d58eb6 100644 --- a/src/mainboard/intel/wtm2/dsdt.asl +++ b/src/mainboard/intel/wtm2/dsdt.asl @@ -25,7 +25,7 @@ Scope (_SB) { Device (PCI0) { - #include <soc/intel/broadwell/acpi/systemagent.asl> + #include <soc/intel/broadwell/acpi/hostbridge.asl> #include <soc/intel/broadwell/pch/acpi/pch.asl> } } diff --git a/src/mainboard/purism/librem_bdw/dsdt.asl b/src/mainboard/purism/librem_bdw/dsdt.asl index a4b5bd8..3c0041e 100644 --- a/src/mainboard/purism/librem_bdw/dsdt.asl +++ b/src/mainboard/purism/librem_bdw/dsdt.asl @@ -21,7 +21,7 @@ Scope (_SB) { Device (PCI0) { - #include <soc/intel/broadwell/acpi/systemagent.asl> + #include <soc/intel/broadwell/acpi/hostbridge.asl> #include <soc/intel/broadwell/pch/acpi/pch.asl> } } diff --git a/src/soc/intel/broadwell/acpi/systemagent.asl b/src/soc/intel/broadwell/acpi/hostbridge.asl similarity index 100% rename from src/soc/intel/broadwell/acpi/systemagent.asl rename to src/soc/intel/broadwell/acpi/hostbridge.asl
-
Angel Pons (Code Review) -
Michael Niewöhner (Code Review)