Attention is currently required from: Jeremy Soller, Paul Menzel, Angel Pons, Arthur Heymans.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56888 )
Change subject: mb/system76/*: Add CMOS option table
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56888/comment/e60c1393_47a5789d
PS1, Line 10: providing a generic layout.
… with the defaults: […]
Done
File src/mainboard/system76/gaze15/cmos.layout:
https://review.coreboot.org/c/coreboot/+/56888/comment/9c70ded7_c26e7b7d
PS1, Line 17: 1 0 Disable
: 1 1 Enable
Indeed. […]
Removed the unused enum.
Almost every other board in the tree uses these indices for these values, so I kept them consistent.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56888
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie57b0e5713bba8ad46e1a4123a3ddd43e0eea964
Gerrit-Change-Number: 56888
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 10 Aug 2021 13:19:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment