Attention is currently required from: Michał Żygowski, Christian Walter, Julius Werner, Sergii Dmytruk.
Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69159 )
Change subject: security/tpm: make tis_probe() return tpm_family
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/i2c/tpm/tpm.c:
https://review.coreboot.org/c/coreboot/+/69159/comment/c4b64421_dd2a5640
PS1, Line 461: *tpm_family = 1;
Are you sure this is guaranteed? I thought I recall that 9645 can be 2. […]
TPM 2.0 for I2C does exist and it should be detected in the same way as for SPI/LPC. That being said, those tests aren't complete because they only test TIS version. Full check, regardless of bus, should be something like:
```
if (TPM_INTF_CAPABILITY.InterfaceVersion == 0)
tpm_family = 1 // (TIS <= 1.21, not used by TPM 2.0 devices)
else // (TIS 1.3, used both by TPM 1.2 and 2.0)
if (TPM_STS.tpmFamily == 0)
tpm_family = 1
else
tpm_family = 2
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69159
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5006e0cdfef76ff79ce9e1cf280fcd5515ae01b0
Gerrit-Change-Number: 69159
Gerrit-PatchSet: 1
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Thu, 10 Nov 2022 08:42:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment