Attention is currently required from: Lance Zhao, Martin Roth, Tim Wawrzynczak, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62817 )
Change subject: [WIP]src/*: Fix void pointer aritmetics ......................................................................
Patch Set 1:
(6 comments)
File src/commonlib/bsd/cbfs_mcache.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143980): https://review.coreboot.org/c/coreboot/+/62817/comment/e81c14b3_2f6f9858 PS1, Line 129: uintptr_t current = (uintptr_t)mcache; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143980): https://review.coreboot.org/c/coreboot/+/62817/comment/4060e0ae_d4af75b2 PS1, Line 129: uintptr_t current = (uintptr_t)mcache; please, no spaces at the start of a line
File src/commonlib/bsd/cbfs_private.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143980): https://review.coreboot.org/c/coreboot/+/62817/comment/ac96cdd7_bdc23bde PS1, Line 177: const struct cbfs_file_attribute *attr = (const void *)((uintptr_t)mdata->raw + offset); line over 96 characters
File src/commonlib/bsd/lz4_wrapper.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143980): https://review.coreboot.org/c/coreboot/+/62817/comment/321f4e28_4337fe18 PS1, Line 153: (uintptr_t)dst + dstn - (uintptr_t)out, endOnInputSize, line over 96 characters
File src/lib/cbfs.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143980): https://review.coreboot.org/c/coreboot/+/62817/comment/5fd98a2d_324040d7 PS1, Line 569: void *compr_start = (void *)((uintptr_t)prog_start(pstage) + prog_size(pstage) - in_size); line over 96 characters
File src/lib/rmodule.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143980): https://review.coreboot.org/c/coreboot/+/62817/comment/de1e7f5a_42fb4263 PS1, Line 267: if (rmodule_load((void *)((uintptr_t)rmod_loc + sizeof(struct rmodule_header)), &rmod_stage)) line over 96 characters