Attention is currently required from: Arthur Heymans, Cliff Huang, Felix Singer, Fred Reitberger, Jason Glenesk, Jeff Daly, Lance Zhao, Matt DeVillier, Raul Rangel, Tim Wawrzynczak, Vanessa Eusebio.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76128?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: acpi: Move HPET generation to a common location
......................................................................
Patch Set 11:
(4 comments)
File src/acpi/Kconfig:
https://review.coreboot.org/c/coreboot/+/76128/comment/b365c432_05110c23 :
PS11, Line 101:
not sure why this second newline is added
File src/soc/amd/common/block/acpi/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/76128/comment/a03f043c_5eebd533 :
PS11, Line 8: ramstage-y += tables.c
that has still parts that are used
File src/soc/amd/common/block/include/amdblocks/acpi.h:
https://review.coreboot.org/c/coreboot/+/76128/comment/1203e0ed_2829122a :
PS11, Line 60: unsigned long southbridge_write_acpi_tables(const struct device *device, unsigned long current,
still needed
File src/soc/amd/common/block/lpc/lpc.c:
https://review.coreboot.org/c/coreboot/+/76128/comment/0fd2fab2_2afcb984 :
PS11, Line 317: .write_acpi_tables = southbridge_write_acpi_tables,
still needed for acpi_16550_mmio32_write_dbg2_uart
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76128?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I38b9962a8d568267356256a3edc51348b9417e20
Gerrit-Change-Number: 76128
Gerrit-PatchSet: 11
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Wed, 21 Feb 2024 21:13:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment