Attention is currently required from: Henry Sun, Paul Menzel, Paul2 Huang.
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59856 )
Change subject: mb/google/octopus: add ALC5682I-VS to be supported in the SSFC
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/octopus/mainboard.c:
https://review.coreboot.org/c/coreboot/+/59856/comment/760abdee_5970a453
PS4, Line 218: cfg->hid = "RTL5682";
Just a guess - the `register "name" = ""RT58""` is the same between VD and VS objects so maybe we do […]
More discussion in b/209707713 and the result is that objects in a single slave address will be seen as one only. Therefore we can only have 1 object and update HID accordingly based on SSFC config as early patch designed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59856
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80be12d88e100ce8586371fc49b36447859e24f8
Gerrit-Change-Number: 59856
Gerrit-PatchSet: 6
Gerrit-Owner: Paul2 Huang
paul2_huang@pegatron.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul2 Huang
paul2_huang@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Thu, 09 Dec 2021 08:27:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul2 Huang
paul2_huang@pegatron.corp-partner.google.com
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Gerrit-MessageType: comment