Change in coreboot[master]: soc/intel/common: Calculate and configure SF Mask 2

[Arthur Heymans (Code Review)]

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56717 )

Change subject: soc/intel/common: Calculate and configure SF Mask 2
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

File src/soc/intel/common/block/cpu/car/cache_as_ram.S:

https://review.coreboot.org/c/coreboot/+/56717/comment/8a6330b5_47b01dbe 
PS1, Line 540: mov	%ebx, %eax /* restore data_ways in eax */
             : 	xorl	%edx, %edx
             : 	mov	$IA32_CR_SF_QOS_MASK_2, %ecx
             : 	wrmsr
> Yes, i hope comment at line 527 is helpful to set this expectation.
>
> /*
> Program MSR 0x1892 Non-Eviction Mask #2
> IA32_CR_SF_QOS_MASK_2 = ((1 << data_ways) - 1)
>
> */
>
> Also comment msg explains it in more details. please let me know if you think we should add that in comment section as well ?
>
> Calculate SF masks:
> if CONFIG_SF_MASK_2BITS_PER_WAY:
>      a. data_ways = data_ways / 2
>
> Also, program SF Mask#2 using below logic:
> 2. Set SF_MASK_2 = (1 << data_ways) - 1

I think adding this as a comment would indeed be good, thanks.