Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/36801 )
Change subject: Fix markdown format ......................................................................
Fix markdown format
There needs to be a new line before tables for them to show up correctly in the atom editor's markdown preview mode.
Change-Id: I70b4d6d22278dceb8184257f3858057ec2952c68 Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M usb-protocol.md 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/em100 refs/changes/01/36801/1
diff --git a/usb-protocol.md b/usb-protocol.md index 6164399..166a528 100644 --- a/usb-protocol.md +++ b/usb-protocol.md @@ -14,6 +14,7 @@ ### 1.1. Get Firmware / FPGA version
USB Out: + | Command | Parameter | Data | |---------|-----------|------| | 0x10 | None | None | @@ -92,6 +93,7 @@ ### 1.4. Set LED
USB Out: + | Command | Parameter | Data | |---------|----------------|------| | 0x13 | LED State (1B) | None | @@ -113,6 +115,7 @@ ### 2.1. Reconfig FPGA:
USB Out: + | Command | Parameter | Data | |---------|-----------|------| | 0x20 | None | None | @@ -129,11 +132,13 @@ ### 2.2. Check FPGA configuration status:
USB Out: + | Command | Parameter | Data | |---------|-----------|------| | 0x21 | None | None |
USB In: + | Result | Data | |-----------|------| | Pass/Fail | None | @@ -148,11 +153,13 @@ ### 2.3. Read FPGA Registers
USB Out: + | Command | Parameter | Data | |---------|--------------|------| | 0x22 | RegAddr (1B) | None |
USB In: + | Result | Data | |--------|------------| | DCNT | Value (2B) | @@ -166,6 +173,7 @@ ### 2.4. Reconfig FPGA:
USB Out: + | Command | Parameter | Data | |---------|-------------|-----------| | 0x23 | RegAddr(1B) | Value(2B) | @@ -271,6 +279,7 @@ ### 3.6. Erase SPI flash sector:
USB Out: + | Command | Parameter | Data | |---------|--------------|------| | 0x37 | SectorNo(1B) | None | @@ -369,6 +378,7 @@ | Data to be written to dFIFO |
USB In: + | Result | Data | |--------|------| | DCNT | None |
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/em100/+/36801 )
Change subject: Fix markdown format ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/em100/+/36801 )
Change subject: Fix markdown format ......................................................................
Fix markdown format
There needs to be a new line before tables for them to show up correctly in the atom editor's markdown preview mode.
Change-Id: I70b4d6d22278dceb8184257f3858057ec2952c68 Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Reviewed-on: https://review.coreboot.org/c/em100/+/36801 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M usb-protocol.md 1 file changed, 10 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/usb-protocol.md b/usb-protocol.md index 6164399..166a528 100644 --- a/usb-protocol.md +++ b/usb-protocol.md @@ -14,6 +14,7 @@ ### 1.1. Get Firmware / FPGA version
USB Out: + | Command | Parameter | Data | |---------|-----------|------| | 0x10 | None | None | @@ -92,6 +93,7 @@ ### 1.4. Set LED
USB Out: + | Command | Parameter | Data | |---------|----------------|------| | 0x13 | LED State (1B) | None | @@ -113,6 +115,7 @@ ### 2.1. Reconfig FPGA:
USB Out: + | Command | Parameter | Data | |---------|-----------|------| | 0x20 | None | None | @@ -129,11 +132,13 @@ ### 2.2. Check FPGA configuration status:
USB Out: + | Command | Parameter | Data | |---------|-----------|------| | 0x21 | None | None |
USB In: + | Result | Data | |-----------|------| | Pass/Fail | None | @@ -148,11 +153,13 @@ ### 2.3. Read FPGA Registers
USB Out: + | Command | Parameter | Data | |---------|--------------|------| | 0x22 | RegAddr (1B) | None |
USB In: + | Result | Data | |--------|------------| | DCNT | Value (2B) | @@ -166,6 +173,7 @@ ### 2.4. Reconfig FPGA:
USB Out: + | Command | Parameter | Data | |---------|-------------|-----------| | 0x23 | RegAddr(1B) | Value(2B) | @@ -271,6 +279,7 @@ ### 3.6. Erase SPI flash sector:
USB Out: + | Command | Parameter | Data | |---------|--------------|------| | 0x37 | SectorNo(1B) | None | @@ -369,6 +378,7 @@ | Data to be written to dFIFO |
USB In: + | Result | Data | |--------|------| | DCNT | None |
-
Patrick Georgi (Code Review) -
Stefan Reinauer (Code Review)