Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Julius Werner, Kapil Porwal, Rishika Raj, Subrata Banik, Tarun.
Paul Menzel has posted comments on this change by Rishika Raj. ( https://review.coreboot.org/c/coreboot/+/83540?usp=email )
Change subject: soc/intel/meteorlake: Change DCACHE_BSP_STACK_SIZE
......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83540/comment/7816f44f_425bb2d0?usp... :
PS1, Line 2: rishikraj
Please use Rishika Raj:
$ git config --global user.name "Rishika Raj"
$ git commit --amend -s --author="Rishika Raj rishikaraj@google.com"
https://review.coreboot.org/c/coreboot/+/83540/comment/813fcad8_26e575eb?usp... :
PS1, Line 7: soc/intel/meteorlake: Change DCACHE_BSP_STACK_SIZE
Maybe even:
Increase CAR stack size by 31 kB for …
https://review.coreboot.org/c/coreboot/+/83540/comment/6d696486_5b290883?usp... :
PS1, Line 9: as required by the coreboot
Please elaborate.
https://review.coreboot.org/c/coreboot/+/83540/comment/7b5a2666_b9994365?usp... :
PS1, Line 9: 1KB to 512KB + 32KB
Use just one space where there are two?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83540?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iba3620b3b7c470176330f5e07989cd3f6238713e
Gerrit-Change-Number: 83540
Gerrit-PatchSet: 1
Gerrit-Owner: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Thu, 18 Jul 2024 08:51:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com