Attention is currently required from: Maxim.
Nicholas Sudsgaard has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/84101?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: util/hda-decoder: Protect 'fields' slice if empty string ......................................................................
Patch Set 2:
(1 comment)
File util/hda-decoder/main.go:
https://review.coreboot.org/c/coreboot/+/84101/comment/b7fb9983_f47d0826?usp... : PS2, Line 73: Something went wrong Let's be a little bit more descriptive than that. Also, I would not make that a comment, I want to prevent anyone from accidentally copy-pasting the output with errors by making it not compile. ```suggestion fmt.Println("[ERROR] Failed to parse: expected exactly 2 arguments") ```