Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35642 )
Change subject: device/pci: Replace some __SIMPLE_DEVICE__ use ......................................................................
device/pci: Replace some __SIMPLE_DEVICE__ use
Change-Id: Ide9df46b5ff47fea54b9de0e365638a6223c8267 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/include/device/pci_ops.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/35642/1
diff --git a/src/include/device/pci_ops.h b/src/include/device/pci_ops.h index 5cc803c..5371e07 100644 --- a/src/include/device/pci_ops.h +++ b/src/include/device/pci_ops.h @@ -178,7 +178,7 @@ u16 pci_s_find_next_capability(pci_devfn_t dev, u16 cap, u16 last); u16 pci_s_find_capability(pci_devfn_t dev, u16 cap);
-#ifndef __SIMPLE_DEVICE__ +#ifndef __ROMCC__ static __always_inline u16 pci_find_next_capability(const struct device *dev, u16 cap, u16 last) {
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35642 )
Change subject: device/pci: Replace some __SIMPLE_DEVICE__ use ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35642 )
Change subject: device/pci: Replace some __SIMPLE_DEVICE__ use ......................................................................
device/pci: Replace some __SIMPLE_DEVICE__ use
Change-Id: Ide9df46b5ff47fea54b9de0e365638a6223c8267 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35642 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/include/device/pci_ops.h 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved
diff --git a/src/include/device/pci_ops.h b/src/include/device/pci_ops.h index 5cc803c..5371e07 100644 --- a/src/include/device/pci_ops.h +++ b/src/include/device/pci_ops.h @@ -178,7 +178,7 @@ u16 pci_s_find_next_capability(pci_devfn_t dev, u16 cap, u16 last); u16 pci_s_find_capability(pci_devfn_t dev, u16 cap);
-#ifndef __SIMPLE_DEVICE__ +#ifndef __ROMCC__ static __always_inline u16 pci_find_next_capability(const struct device *dev, u16 cap, u16 last) {
-
Aaron Durbin (Code Review) -
Kyösti Mälkki (Code Review)