Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83721?usp=email )
Change subject: i2c/drivers/generic: Return ROTM in a package ......................................................................
i2c/drivers/generic: Return ROTM in a package
The ROTM method should return a package:
``` Name (RBUF, Package (0x03) { "0 1 0", "1 0 0", "0 0 1" }) Return (RBUF) ```
Adjust the acpigen to do this.
Change-Id: Id493f6955c1d0dc3449402262a8575091a828226 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/83721 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/drivers/i2c/generic/generic.c 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c index 1875bac..27bef49 100644 --- a/src/drivers/i2c/generic/generic.c +++ b/src/drivers/i2c/generic/generic.c @@ -149,6 +149,7 @@ /* Rotation Matrix */ if (config->has_rotation_matrix) { acpigen_write_method("ROTM", 0); + acpigen_write_name("RBUF"); acpigen_write_package(3);
for (int i = 0; i < 3; i++) { @@ -160,6 +161,8 @@
acpigen_write_string(matrix_row); } + acpigen_pop_len(); + acpigen_write_return_namestr("RBUF");
acpigen_pop_len(); acpigen_pop_len();