Attention is currently required from: Terry Chen, Paul Menzel, Nick Vaccaro, Zhuohao Lee, YH Lin.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62854 )
Change subject: mb/google/brya/variants/crota: set up gpio
......................................................................
Patch Set 7:
(2 comments)
File src/mainboard/google/brya/variants/crota/gpio.c:
https://review.coreboot.org/c/coreboot/+/62854/comment/9c30a1e2_25b87564
PS7, Line 49: /* E22 : DDPA_CTRLCLK ==> USB_C0_AUX_DC_STRAP_P */
: PAD_CFG_NF(GPP_E22, NONE, DEEP, NF6),
Is this supposed to be an AUX DC bias GPIO?
https://review.coreboot.org/c/coreboot/+/62854/comment/92008818_ece636cf
PS7, Line 143: /* A12 : SATAXPCIE1 ==> EN_PPVAR_WWAN (set here for correct power sequencing) */
: PAD_CFG_GPO(GPP_A12, 1, DEEP),
is this the 850-GL ? please follow redrix for guidelines implementing the WWAN power sequencing
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62854
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I164bc7a8b682eb8682f02b06708bc7c72a5c449a
Gerrit-Change-Number: 62854
Gerrit-PatchSet: 7
Gerrit-Owner: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Chi
peter_chi@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Attention: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: YH Lin
yueherngl@chromium.org
Gerrit-Comment-Date: Mon, 21 Mar 2022 22:51:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment