Change in coreboot[master]: mb/prodrive/hermes: Drop Vref configuration for older boards
Attention is currently required from: Patrick Rudolph, Christian Walter. Justin van Son has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51919 )
Change subject: mb/prodrive/hermes: Drop Vref configuration for older boards ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/prodrive/hermes/variants/r04/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/51919/comment/0f61538b_5dbabd05 PS1, Line 42: return AZALIA_PIN_DESC( The driver won't detect a valid pin configuration when AZALIA_PIN_DESC is used. I have no idea why, but when I change this to the hex equivalent as in case 1, it will work fine.
Also, it seems like this configuration makes the driver somehow tie this widget (and thus the output) together with NID 0x14 (green rear line out), causing windows to only have 1 output device, and thus outputting audio to the two devices at the same time. I'm not sure how we can get this separated, even though it should be possible here.
https://review.coreboot.org/c/coreboot/+/51919/comment/6fd62340_1a4f7ff9 PS1, Line 69: 0x018707e1, /* port B VREF 50% of LDO-OUT */ You don't need any of the 707 verbs, as they will get reset by realtek driver anyway
-
Justin van Son (Code Review)