Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21448 )
Change subject: drivers/intel/gma/vbt.c: Add GENERAL DEFINITIONS block to fake vbt ......................................................................
Patch Set 1:
Maybe don't add the general definitions block at all if VGADDC? Other- wise somebody should check if the incomplete general definitions block has any unwanted side effects (e.g. does LVDS still work? DP dual mode? etc.).
good idea. I was thinking that this change be hard to test on all platform using it but restricting to only when needed seems to be a good solution here to avoid potential regressions.