Attention is currently required from: Angel Pons, Dinesh Gehlot, Jérémy Compostella, Nick Vaccaro, Tarun Tuli, Tim Wawrzynczak.
Nico Huber has posted comments on this change by Tim Wawrzynczak. ( https://review.coreboot.org/c/libgfxinit/+/67494?usp=email )
Change subject: gma pipe_setup: Update for TGL & ADL
......................................................................
Patch Set 35:
(2 comments)
File common/hw-gfx-gma-pipe_setup.adb:
https://review.coreboot.org/c/libgfxinit/+/67494/comment/98511f23_de7d12c2?u... :
PS32, Line 249: PLANE_CTL_PLANE_ENABLE
Lost in last refactoring. […]
Fixed
https://review.coreboot.org/c/libgfxinit/+/67494/comment/6a5954d5_cee2b13d?u... :
PS32, Line 266: Value => 0);
Moving this out of the if, because PLANE_AUX_DIST seems to exist since `Has_Plane_Control` and shoul […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/libgfxinit/+/67494?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I93329c0a012da83abc379d6782fabe257dc180f3
Gerrit-Change-Number: 67494
Gerrit-PatchSet: 35
Gerrit-Owner: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-CC: Dinesh Gehlot
digehlot@google.com
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Tue, 23 Jul 2024 12:44:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de