Change in coreboot[master]: mb/google/kukui: Add discrete LPDDR4X DDR table support for burnet/esche
Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43752 )
Change subject: mb/google/kukui: Add discrete LPDDR4X DDR table support for burnet/esche ......................................................................
mb/google/kukui: Add discrete LPDDR4X DDR table support for burnet/esche
LPDDR4x DRAM table for burnet/esche: [1] = "sdram-lpddr4x-H9HCNNNCPMALHR-4GB" [2] = "sdram-lpddr4x-MT53E1G32D4NQ-4GB" [3] = "sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB" [4] = "sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB"
BUG=b:161768221,b:159301679 BRANCH=master TEST=emerge-jacuzzi coreboot Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Change-Id: Ida7ab877c3f7e10a67680b69a1d724ec734d2928 --- M src/mainboard/google/kukui/sdram_configs.c M src/mainboard/google/kukui/sdram_params/Makefile.inc 2 files changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/43752/1
diff --git a/src/mainboard/google/kukui/sdram_configs.c b/src/mainboard/google/kukui/sdram_configs.c index c1e75ef6..0b0a240 100644 --- a/src/mainboard/google/kukui/sdram_configs.c +++ b/src/mainboard/google/kukui/sdram_configs.c @@ -6,6 +6,12 @@ #include <soc/emi.h>
static const char *const sdram_configs[] = { +#if defined(CONFIG_BOARD_GOOGLE_BURNET) + [1] = "sdram-lpddr4x-H9HCNNNCPMALHR-4GB", + [2] = "sdram-lpddr4x-MT53E1G32D4NQ-4GB", + [3] = "sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB", + [4] = "sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB", +#else /* The default unified table */ [1] = "sdram-lpddr4x-H9HCNNNCPMALHR-4GB", [2] = "sdram-lpddr4x-MT53E1G32D4NQ-4GB", [3] = "sdram-lpddr4x-KMDH6001DA-B422-4GB", @@ -15,6 +21,7 @@ [7] = "sdram-lpddr4x-SDADA4CR-128G-4GB", [8] = "sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB", [10] = "sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB", +#endif };
static struct sdram_params params; diff --git a/src/mainboard/google/kukui/sdram_params/Makefile.inc b/src/mainboard/google/kukui/sdram_params/Makefile.inc index af13aa1..29a60c2 100644 --- a/src/mainboard/google/kukui/sdram_params/Makefile.inc +++ b/src/mainboard/google/kukui/sdram_params/Makefile.inc @@ -1,3 +1,10 @@ +ifeq ($(CONFIG_BOARD_GOOGLE_BURNET),y) +sdram-params := +sdram-params += sdram-lpddr4x-H9HCNNNCPMALHR-4GB +sdram-params += sdram-lpddr4x-MT53E1G32D4NQ-4GB +sdram-params += sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB +sdram-params += sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB +else sdram-params := sdram-params += sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB sdram-params += sdram-lpddr4x-H9HCNNNCPMALHR-4GB @@ -8,6 +15,7 @@ sdram-params += sdram-lpddr4x-KMDV6001DA-B620-4GB sdram-params += sdram-lpddr4x-SDADA4CR-128G-4GB sdram-params += sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB +endif
$(foreach params,$(sdram-params), \ $(eval cbfs-files-y += $(params)) \
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43752
to look at the new patch set (#2).
Change subject: mb/google/kukui: Add discrete LPDDR4X DDR table support for burnet/esche ......................................................................
mb/google/kukui: Add discrete LPDDR4X DDR table support for burnet/esche
LPDDR4x DRAM table for burnet/esche: [1] = "sdram-lpddr4x-H9HCNNNCPMALHR-4GB" [2] = "sdram-lpddr4x-MT53E1G32D4NQ-4GB" [3] = "sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB" [4] = "sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB"
BUG=b:161768221,b:159301679 BRANCH=master TEST=emerge-jacuzzi coreboot Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Change-Id: Ida7ab877c3f7e10a67680b69a1d724ec734d2928 --- M src/mainboard/google/kukui/sdram_configs.c M src/mainboard/google/kukui/sdram_params/Makefile.inc 2 files changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/43752/2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43752 )
Change subject: mb/google/kukui: Add discrete LPDDR4X DDR table support for burnet/esche ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43752/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/sdram_params/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/43752/2/src/mainboard/google/kukui/... PS2, Line 8: dram-params := Please indent properly and move 'sdram-params :=' to outside the ifeq block, e.g.,
sdram-params := ifeq ($(CONFIG_BOARD_GOOGLE_BURNET),y) sdram-params += ... else # Default memory table sdram-params += ... endif
Hello Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43752
to look at the new patch set (#3).
Change subject: mb/google/kukui: Add discrete LPDDR4X DDR table support for burnet/esche ......................................................................
mb/google/kukui: Add discrete LPDDR4X DDR table support for burnet/esche
LPDDR4x DRAM table for burnet/esche: [1] = "sdram-lpddr4x-H9HCNNNCPMALHR-4GB" [2] = "sdram-lpddr4x-MT53E1G32D4NQ-4GB" [3] = "sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB" [4] = "sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB"
BUG=b:161768221,b:159301679 BRANCH=master TEST=emerge-jacuzzi coreboot Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Change-Id: Ida7ab877c3f7e10a67680b69a1d724ec734d2928 --- M src/mainboard/google/kukui/sdram_configs.c M src/mainboard/google/kukui/sdram_params/Makefile.inc 2 files changed, 23 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/43752/3
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43752 )
Change subject: mb/google/kukui: Add discrete LPDDR4X DDR table support for burnet/esche ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43752/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/sdram_params/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/43752/2/src/mainboard/google/kukui/... PS2, Line 8: dram-params :=
Please indent properly and move 'sdram-params :=' to outside the ifeq block, e.g., […]
Done
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43752 )
Change subject: mb/google/kukui: Add discrete LPDDR4X DDR table support for burnet/esche ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43752 )
Change subject: mb/google/kukui: Add discrete LPDDR4X DDR table support for burnet/esche ......................................................................
mb/google/kukui: Add discrete LPDDR4X DDR table support for burnet/esche
LPDDR4x DRAM table for burnet/esche: [1] = "sdram-lpddr4x-H9HCNNNCPMALHR-4GB" [2] = "sdram-lpddr4x-MT53E1G32D4NQ-4GB" [3] = "sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB" [4] = "sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB"
BUG=b:161768221,b:159301679 BRANCH=master TEST=emerge-jacuzzi coreboot Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Change-Id: Ida7ab877c3f7e10a67680b69a1d724ec734d2928 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43752 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Hung-Te Lin hungte@chromium.org --- M src/mainboard/google/kukui/sdram_configs.c M src/mainboard/google/kukui/sdram_params/Makefile.inc 2 files changed, 23 insertions(+), 9 deletions(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved
diff --git a/src/mainboard/google/kukui/sdram_configs.c b/src/mainboard/google/kukui/sdram_configs.c index c1e75ef6..7638853 100644 --- a/src/mainboard/google/kukui/sdram_configs.c +++ b/src/mainboard/google/kukui/sdram_configs.c @@ -6,6 +6,12 @@ #include <soc/emi.h>
static const char *const sdram_configs[] = { +#if CONFIG(BOARD_GOOGLE_BURNET) + [1] = "sdram-lpddr4x-H9HCNNNCPMALHR-4GB", + [2] = "sdram-lpddr4x-MT53E1G32D4NQ-4GB", + [3] = "sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB", + [4] = "sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB", +#else /* The default unified table */ [1] = "sdram-lpddr4x-H9HCNNNCPMALHR-4GB", [2] = "sdram-lpddr4x-MT53E1G32D4NQ-4GB", [3] = "sdram-lpddr4x-KMDH6001DA-B422-4GB", @@ -15,6 +21,7 @@ [7] = "sdram-lpddr4x-SDADA4CR-128G-4GB", [8] = "sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB", [10] = "sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB", +#endif };
static struct sdram_params params; diff --git a/src/mainboard/google/kukui/sdram_params/Makefile.inc b/src/mainboard/google/kukui/sdram_params/Makefile.inc index af13aa1..2b43519 100644 --- a/src/mainboard/google/kukui/sdram_params/Makefile.inc +++ b/src/mainboard/google/kukui/sdram_params/Makefile.inc @@ -1,13 +1,20 @@ sdram-params := -sdram-params += sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB -sdram-params += sdram-lpddr4x-H9HCNNNCPMALHR-4GB -sdram-params += sdram-lpddr4x-MT53E1G32D4NQ-4GB -sdram-params += sdram-lpddr4x-KMDH6001DA-B422-4GB -sdram-params += sdram-lpddr4x-KMDP6001DA-B425-4GB -sdram-params += sdram-lpddr4x-MT29VZZZAD8DQKSL-4GB -sdram-params += sdram-lpddr4x-KMDV6001DA-B620-4GB -sdram-params += sdram-lpddr4x-SDADA4CR-128G-4GB -sdram-params += sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB +ifeq ($(CONFIG_BOARD_GOOGLE_BURNET),y) + sdram-params += sdram-lpddr4x-H9HCNNNCPMALHR-4GB + sdram-params += sdram-lpddr4x-MT53E1G32D4NQ-4GB + sdram-params += sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB + sdram-params += sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB +else + sdram-params += sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB + sdram-params += sdram-lpddr4x-H9HCNNNCPMALHR-4GB + sdram-params += sdram-lpddr4x-MT53E1G32D4NQ-4GB + sdram-params += sdram-lpddr4x-KMDH6001DA-B422-4GB + sdram-params += sdram-lpddr4x-KMDP6001DA-B425-4GB + sdram-params += sdram-lpddr4x-MT29VZZZAD8DQKSL-4GB + sdram-params += sdram-lpddr4x-KMDV6001DA-B620-4GB + sdram-params += sdram-lpddr4x-SDADA4CR-128G-4GB + sdram-params += sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB +endif
$(foreach params,$(sdram-params), \ $(eval cbfs-files-y += $(params)) \
-
Hung-Te Lin (Code Review) -
Kevin Chiu (Code Review)
-
Patrick Georgi (Code Review)