HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42795 )
Change subject: src: Remove uneeded white spaces ......................................................................
src: Remove uneeded white spaces
Remove white spaces before tabs.
Change-Id: I73695152ec8d8ab2dabf8421ef2405f70de0f4ba Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/asus/p2b/variants/p2b-ls/overridetree.cb M src/mainboard/facebook/fbg1701/spd/KINGSTON_B5116ECMDXGGB.spd.hex M src/mainboard/facebook/fbg1701/spd/MICRON_MT41K512M16HA-125A.spd.hex M src/mainboard/facebook/fbg1701/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex M src/mainboard/portwell/m107/spd/KINGSTON_B5116ECMDXGGB.spd.hex M src/mainboard/portwell/m107/spd/MICRON_MT41K512M16HA-125A.spd.hex M src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex M src/mainboard/prodrive/hermes/devicetree.cb M src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb M src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb M src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb M src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb M src/soc/intel/cannonlake/acpi/scs.asl M src/soc/intel/common/acpi/lpit.asl M src/soc/intel/tigerlake/acpi/tcss.asl M src/soc/intel/tigerlake/acpi/tcss_dma.asl M src/soc/intel/xeon_sp/cpx/acpi/uncore_irq.asl 17 files changed, 24 insertions(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/42795/1
diff --git a/src/mainboard/asus/p2b/variants/p2b-ls/overridetree.cb b/src/mainboard/asus/p2b/variants/p2b-ls/overridetree.cb index 541db02..77d3bb0 100644 --- a/src/mainboard/asus/p2b/variants/p2b-ls/overridetree.cb +++ b/src/mainboard/asus/p2b/variants/p2b-ls/overridetree.cb @@ -3,8 +3,8 @@ chip southbridge/intel/i82371eb # Southbridge register "gpo" = "0x7fbfb9ff" register "gpo22_enable" = "1" # GPO22 controls LVD port termination (0=enabled) - # GPO23 controls SCSI-50 port termination (1=enabled) - # SCSI-68 port is always terminated + # GPO23 controls SCSI-50 port termination (1=enabled) + # SCSI-68 port is always terminated device pci 4.0 on # ISA bridge chip superio/winbond/w83977tf # Super I/O device pnp 3f0.a off # ACPI diff --git a/src/mainboard/facebook/fbg1701/spd/KINGSTON_B5116ECMDXGGB.spd.hex b/src/mainboard/facebook/fbg1701/spd/KINGSTON_B5116ECMDXGGB.spd.hex index bce16cc..c51a5b901 100644 --- a/src/mainboard/facebook/fbg1701/spd/KINGSTON_B5116ECMDXGGB.spd.hex +++ b/src/mainboard/facebook/fbg1701/spd/KINGSTON_B5116ECMDXGGB.spd.hex @@ -170,7 +170,7 @@ 00
# 33 SDRAM device type -# byte [1:0] : 00b = Signal Loading not specified +# byte [1:0] : 00b = Signal Loading not specified # byte [6:4] : 000b = Die count not specified # byte [7] : 0 = Standard Monolithic DRAM Device 00 diff --git a/src/mainboard/facebook/fbg1701/spd/MICRON_MT41K512M16HA-125A.spd.hex b/src/mainboard/facebook/fbg1701/spd/MICRON_MT41K512M16HA-125A.spd.hex index fa55389..5007a26 100644 --- a/src/mainboard/facebook/fbg1701/spd/MICRON_MT41K512M16HA-125A.spd.hex +++ b/src/mainboard/facebook/fbg1701/spd/MICRON_MT41K512M16HA-125A.spd.hex @@ -170,7 +170,7 @@ 00
# 33 SDRAM device type -# byte [1:0] : 00b = Signal Loading not specified +# byte [1:0] : 00b = Signal Loading not specified # byte [6:4] : 000b = Die count not specified # byte [7] : 1 = Non-Standard Device 80 diff --git a/src/mainboard/facebook/fbg1701/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex b/src/mainboard/facebook/fbg1701/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex index 11ec821..c3b71d6 100644 --- a/src/mainboard/facebook/fbg1701/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex +++ b/src/mainboard/facebook/fbg1701/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex @@ -168,7 +168,7 @@
# 33 SDRAM device type # byte [1:0] : 01b = multi load stack -# byte [6:4] : 100b = 8 die +# byte [6:4] : 100b = 8 die # byte [7] : 0 = Standard Device 41
diff --git a/src/mainboard/portwell/m107/spd/KINGSTON_B5116ECMDXGGB.spd.hex b/src/mainboard/portwell/m107/spd/KINGSTON_B5116ECMDXGGB.spd.hex index bce16cc..c51a5b901 100644 --- a/src/mainboard/portwell/m107/spd/KINGSTON_B5116ECMDXGGB.spd.hex +++ b/src/mainboard/portwell/m107/spd/KINGSTON_B5116ECMDXGGB.spd.hex @@ -170,7 +170,7 @@ 00
# 33 SDRAM device type -# byte [1:0] : 00b = Signal Loading not specified +# byte [1:0] : 00b = Signal Loading not specified # byte [6:4] : 000b = Die count not specified # byte [7] : 0 = Standard Monolithic DRAM Device 00 diff --git a/src/mainboard/portwell/m107/spd/MICRON_MT41K512M16HA-125A.spd.hex b/src/mainboard/portwell/m107/spd/MICRON_MT41K512M16HA-125A.spd.hex index fa55389..5007a26 100644 --- a/src/mainboard/portwell/m107/spd/MICRON_MT41K512M16HA-125A.spd.hex +++ b/src/mainboard/portwell/m107/spd/MICRON_MT41K512M16HA-125A.spd.hex @@ -170,7 +170,7 @@ 00
# 33 SDRAM device type -# byte [1:0] : 00b = Signal Loading not specified +# byte [1:0] : 00b = Signal Loading not specified # byte [6:4] : 000b = Die count not specified # byte [7] : 1 = Non-Standard Device 80 diff --git a/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex b/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex index 11ec821..c3b71d6 100644 --- a/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex +++ b/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex @@ -168,7 +168,7 @@
# 33 SDRAM device type # byte [1:0] : 01b = multi load stack -# byte [6:4] : 100b = 8 die +# byte [6:4] : 100b = 8 die # byte [7] : 0 = Standard Device 41
diff --git a/src/mainboard/prodrive/hermes/devicetree.cb b/src/mainboard/prodrive/hermes/devicetree.cb index c55ac92..532254b 100644 --- a/src/mainboard/prodrive/hermes/devicetree.cb +++ b/src/mainboard/prodrive/hermes/devicetree.cb @@ -34,7 +34,7 @@ device pci 00.0 on end # Aspeed 2500 VGA end end # PCIe - device pci 1f.0 on # LPC Interface + device pci 1f.0 on # LPC Interface chip drivers/pc80/tpm device pnp 0c31.0 on end end diff --git a/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb b/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb index 3388239..0de19ef 100644 --- a/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb +++ b/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb @@ -25,7 +25,7 @@ # Enumeration starts at 0 for PCIE1 # Ports are not hotplugable register "PcieRpEnable[0]" = "1" # Slot3 x4 - # Set MaxPayload to 256 bytes + # Set MaxPayload to 256 bytes register "PcieRpMaxPayload[0]" = "RpMaxPayload_256" # Enable Latency Tolerance Reporting Mechanism register "PcieRpLtrEnable[0]" = "1" diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb index 4074bae..be50408 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb @@ -93,7 +93,7 @@ device pci 1c.0 on end # - eMMC device pci 1d.0 off end # - UFS device pci 1e.0 off end # - SDIO - device pci 1f.0 on # - LPC + device pci 1f.0 on # - LPC chip drivers/pc80/tpm device pnp 0c31.0 on end end diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb index 723ecb3..33664fe 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb @@ -108,7 +108,7 @@ device pci 1c.0 on end # - eMMC device pci 1d.0 off end # - UFS device pci 1e.0 off end # - SDIO - device pci 1f.0 on # - LPC + device pci 1f.0 on # - LPC chip drivers/pc80/tpm device pnp 0c31.0 on end end diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb index 3b52f65..a865f9f 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb @@ -72,7 +72,7 @@ device pci 1c.0 off end # - eMMC device pci 1d.0 off end # - UFS device pci 1e.0 off end # - SDIO - device pci 1f.0 on # - LPC + device pci 1f.0 on # - LPC chip drivers/pc80/tpm device pnp 0c31.0 on end end diff --git a/src/soc/intel/cannonlake/acpi/scs.asl b/src/soc/intel/cannonlake/acpi/scs.asl index ae0afc8..8e1de1e 100644 --- a/src/soc/intel/cannonlake/acpi/scs.asl +++ b/src/soc/intel/cannonlake/acpi/scs.asl @@ -82,7 +82,7 @@ * containing one bit for each function index, starting * with zero. * Bit 0 - Indicates whether there is support for any - * functions other than function 0 + * functions other than function 0 * Bit 1 - Indicates support to clear power control * register * Bit 2 - Indicates support to set power control diff --git a/src/soc/intel/common/acpi/lpit.asl b/src/soc/intel/common/acpi/lpit.asl index b81275e..348ae56 100644 --- a/src/soc/intel/common/acpi/lpit.asl +++ b/src/soc/intel/common/acpi/lpit.asl @@ -69,7 +69,7 @@ /* * Save the current PM bits then * enable GPIO PM with MISCCFG_ENABLE_GPIO_PM_CONFIG - */ + */ If (CondRefOf (_SB.PCI0.EGPM)) { _SB.PCI0.EGPM () diff --git a/src/soc/intel/tigerlake/acpi/tcss.asl b/src/soc/intel/tigerlake/acpi/tcss.asl index 3f51ecc..c635bb1 100644 --- a/src/soc/intel/tigerlake/acpi/tcss.asl +++ b/src/soc/intel/tigerlake/acpi/tcss.asl @@ -356,7 +356,7 @@ * Poll pCode MailBox Ready * * Return 0xFF - Timeout - * 0x00 - Ready + * 0x00 - Ready */ Method (PMBY, 0) { @@ -382,13 +382,13 @@ * DATA[1:1] TCSS_DEVEN_REQUEST_STATUS: * 0 - IDLE. TCSS DEVEN has reached its final requested state. * 1 - In Progress. TCSS DEVEN is currently in progress of switching state - * according to given request (bit 0 reflects source state). + * according to given request (bit 0 reflects source state). * * Return 0x00 - TCSS Deven in normal state - * 0x01 - TCSS Deven is cleared by BIOS Mailbox request - * 0x1x - TCSS Deven is in progress of switching state according to given request - * 0xFE - Command timeout - * 0xFF - Command corrupt + * 0x01 - TCSS Deven is cleared by BIOS Mailbox request + * 0x1x - TCSS Deven is in progress of switching state according to given request + * 0xFE - Command timeout + * 0xFF - Command corrupt */ Method (DSGS, 0) { diff --git a/src/soc/intel/tigerlake/acpi/tcss_dma.asl b/src/soc/intel/tigerlake/acpi/tcss_dma.asl index 8eab92f..3d44d92 100644 --- a/src/soc/intel/tigerlake/acpi/tcss_dma.asl +++ b/src/soc/intel/tigerlake/acpi/tcss_dma.asl @@ -56,7 +56,7 @@ */ Method (D3CX, 0, Serialized) { - DD3E = 0 /* Disable DMA RTD3 */ + DD3E = 0 /* Disable DMA RTD3 */ STAT = 0x1 }
@@ -65,7 +65,7 @@ */ Method (D3CE, 0, Serialized) { - DD3E = 1 /* Enable DMA RTD3 */ + DD3E = 1 /* Enable DMA RTD3 */ STAT = 0 }
diff --git a/src/soc/intel/xeon_sp/cpx/acpi/uncore_irq.asl b/src/soc/intel/xeon_sp/cpx/acpi/uncore_irq.asl index d83bf26..0505152 100644 --- a/src/soc/intel/xeon_sp/cpx/acpi/uncore_irq.asl +++ b/src/soc/intel/xeon_sp/cpx/acpi/uncore_irq.asl @@ -6,7 +6,7 @@ * The mapping fields ae Address, Pin, Source, Source Index. */
-#define GEN_PCIE_LEGACY_IRQ() \ +#define GEN_PCIE_LEGACY_IRQ() \ Package () { 0x0000FFFF, 0x00, LNKA, 0x00 }, \ Package () { 0x0001FFFF, 0x01, LNKB, 0x00 }, \ Package () { 0x0002FFFF, 0x02, LNKC, 0x00 }, \
Hello Frans Hendriks, Werner Zeh, Patrick Rudolph, Wim Vervoorn,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42795
to look at the new patch set (#2).
Change subject: src: Remove unneeded white spaces ......................................................................
src: Remove unneeded white spaces
Remove white spaces before tabs.
Change-Id: I73695152ec8d8ab2dabf8421ef2405f70de0f4ba Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/asus/p2b/variants/p2b-ls/overridetree.cb M src/mainboard/facebook/fbg1701/spd/KINGSTON_B5116ECMDXGGB.spd.hex M src/mainboard/facebook/fbg1701/spd/MICRON_MT41K512M16HA-125A.spd.hex M src/mainboard/facebook/fbg1701/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex M src/mainboard/portwell/m107/spd/KINGSTON_B5116ECMDXGGB.spd.hex M src/mainboard/portwell/m107/spd/MICRON_MT41K512M16HA-125A.spd.hex M src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex M src/mainboard/prodrive/hermes/devicetree.cb M src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb M src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb M src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb M src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb M src/soc/intel/cannonlake/acpi/scs.asl M src/soc/intel/common/acpi/lpit.asl M src/soc/intel/tigerlake/acpi/tcss.asl M src/soc/intel/tigerlake/acpi/tcss_dma.asl M src/soc/intel/xeon_sp/cpx/acpi/uncore_irq.asl 17 files changed, 24 insertions(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/42795/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42795 )
Change subject: src: Remove unneeded white spaces ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42795/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42795/2//COMMIT_MSG@9 PS2, Line 9: Remove white spaces before tabs. Please use this line as the commit message summary.
https://review.coreboot.org/c/coreboot/+/42795/2/src/mainboard/asus/p2b/vari... File src/mainboard/asus/p2b/variants/p2b-ls/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42795/2/src/mainboard/asus/p2b/vari... PS2, Line 7: # SCSI-68 port is always terminated Interesting case to deal with. The indentation in device tree is done with spaces here, so it could be kept?
https://review.coreboot.org/c/coreboot/+/42795/2/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/42795/2/src/soc/intel/tigerlake/acp... PS2, Line 359: * 0x00 - Ready Spaces instead of the tab should be used for the alignment here.
https://review.coreboot.org/c/coreboot/+/42795/2/src/soc/intel/tigerlake/acp... PS2, Line 388: * 0x01 - TCSS Deven is cleared by BIOS Mailbox request : * 0x1x - TCSS Deven is in progress of switching state according to given request : * 0xFE - Command timeout : * 0xFF - Command corrupt Spaces instead of tabs should be used for alignment here.
Hello build bot (Jenkins), Frans Hendriks, Werner Zeh, Patrick Rudolph, Wim Vervoorn,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42795
to look at the new patch set (#3).
Change subject: src: Remove white spaces before tabs ......................................................................
src: Remove white spaces before tabs
Change-Id: I73695152ec8d8ab2dabf8421ef2405f70de0f4ba Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/asus/p2b/variants/p2b-ls/overridetree.cb M src/mainboard/facebook/fbg1701/spd/KINGSTON_B5116ECMDXGGB.spd.hex M src/mainboard/facebook/fbg1701/spd/MICRON_MT41K512M16HA-125A.spd.hex M src/mainboard/facebook/fbg1701/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex M src/mainboard/portwell/m107/spd/KINGSTON_B5116ECMDXGGB.spd.hex M src/mainboard/portwell/m107/spd/MICRON_MT41K512M16HA-125A.spd.hex M src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex M src/mainboard/prodrive/hermes/devicetree.cb M src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb M src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb M src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb M src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb M src/soc/intel/cannonlake/acpi/scs.asl M src/soc/intel/common/acpi/lpit.asl M src/soc/intel/tigerlake/acpi/tcss.asl M src/soc/intel/tigerlake/acpi/tcss_dma.asl M src/soc/intel/xeon_sp/cpx/acpi/uncore_irq.asl 17 files changed, 24 insertions(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/42795/3
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42795 )
Change subject: src: Remove white spaces before tabs ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42795/2/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/42795/2/src/soc/intel/tigerlake/acp... PS2, Line 388: * 0x01 - TCSS Deven is cleared by BIOS Mailbox request : * 0x1x - TCSS Deven is in progress of switching state according to given request : * 0xFE - Command timeout : * 0xFF - Command corrupt
Spaces instead of tabs should be used for alignment here.
so lines [#380 , #385] also ?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42795 )
Change subject: src: Remove white spaces before tabs ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42795/2/src/mainboard/asus/p2b/vari... File src/mainboard/asus/p2b/variants/p2b-ls/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42795/2/src/mainboard/asus/p2b/vari... PS2, Line 7: # SCSI-68 port is always terminated
Interesting case to deal with. […]
why would you keep ?
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42795 )
Change subject: src: Remove white spaces before tabs ......................................................................
Patch Set 3: Code-Review+2
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42795 )
Change subject: src: Remove white spaces before tabs ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42795/2/src/mainboard/asus/p2b/vari... File src/mainboard/asus/p2b/variants/p2b-ls/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42795/2/src/mainboard/asus/p2b/vari... PS2, Line 7: # SCSI-68 port is always terminated
why would you keep ?
Becaus the lines above are using spaces for indentation as well!? Using TABs just in these two lines instead would be inconsistent.
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42795 )
Change subject: src: Remove white spaces before tabs ......................................................................
Patch Set 3: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42795 )
Change subject: src: Remove white spaces before tabs ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42795/2/src/mainboard/asus/p2b/vari... File src/mainboard/asus/p2b/variants/p2b-ls/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42795/2/src/mainboard/asus/p2b/vari... PS2, Line 7: # SCSI-68 port is always terminated
Becaus the lines above are using spaces for indentation as well!? Using TABs just in these two lines […]
Most devicetrees are indented with tabs nowadays. Maybe handle this in a separate commit?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42795 )
Change subject: src: Remove white spaces before tabs ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42795/2/src/mainboard/asus/p2b/vari... File src/mainboard/asus/p2b/variants/p2b-ls/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42795/2/src/mainboard/asus/p2b/vari... PS2, Line 7: # SCSI-68 port is always terminated
Most devicetrees are indented with tabs nowadays. […]
Done
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42795 )
Change subject: src: Remove white spaces before tabs ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42795/2/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/42795/2/src/soc/intel/tigerlake/acp... PS2, Line 359: * 0x00 - Ready
Spaces instead of the tab should be used for the alignment here.
Done
https://review.coreboot.org/c/coreboot/+/42795/2/src/soc/intel/tigerlake/acp... PS2, Line 388: * 0x01 - TCSS Deven is cleared by BIOS Mailbox request : * 0x1x - TCSS Deven is in progress of switching state according to given request : * 0xFE - Command timeout : * 0xFF - Command corrupt
so lines [#380 , #385] also ?
Done
Hello build bot (Jenkins), Frans Hendriks, Angel Pons, Werner Zeh, Patrick Rudolph, Wim Vervoorn,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42795
to look at the new patch set (#4).
Change subject: src: Remove white spaces before tabs ......................................................................
src: Remove white spaces before tabs
Still "src/mainboard/asus/p2b/variants/p2b-ls/overridetree.cb" using whitespaces before tabs.
Change-Id: I73695152ec8d8ab2dabf8421ef2405f70de0f4ba Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/facebook/fbg1701/spd/KINGSTON_B5116ECMDXGGB.spd.hex M src/mainboard/facebook/fbg1701/spd/MICRON_MT41K512M16HA-125A.spd.hex M src/mainboard/facebook/fbg1701/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex M src/mainboard/portwell/m107/spd/KINGSTON_B5116ECMDXGGB.spd.hex M src/mainboard/portwell/m107/spd/MICRON_MT41K512M16HA-125A.spd.hex M src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex M src/mainboard/prodrive/hermes/devicetree.cb M src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb M src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb M src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb M src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb M src/soc/intel/cannonlake/acpi/scs.asl M src/soc/intel/common/acpi/lpit.asl M src/soc/intel/tigerlake/acpi/tcss_dma.asl M src/soc/intel/xeon_sp/cpx/acpi/uncore_irq.asl 15 files changed, 16 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/42795/4
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42795 )
Change subject: src: Remove white spaces before tabs ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42795/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42795/2//COMMIT_MSG@9 PS2, Line 9: Remove white spaces before tabs.
Please use this line as the commit message summary.
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42795 )
Change subject: src: Remove white spaces before tabs ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/42795/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42795/4//COMMIT_MSG@7 PS4, Line 7: white spaces whitespaces
https://review.coreboot.org/c/coreboot/+/42795/4//COMMIT_MSG@9 PS4, Line 9: Still "src/mainboard/asus/p2b/variants/p2b-ls/overridetree.cb" using whitespaces This is not a gramatically-correct sentence. I'd just omit this from the commit message and handle it in a follow-up.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42795 )
Change subject: src: Remove white spaces before tabs ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42795/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42795/4//COMMIT_MSG@7 PS4, Line 7: white spaces
whitespaces
Done
https://review.coreboot.org/c/coreboot/+/42795/4//COMMIT_MSG@9 PS4, Line 9: Still "src/mainboard/asus/p2b/variants/p2b-ls/overridetree.cb" using whitespaces
This is not a gramatically-correct sentence. […]
Done
Hello build bot (Jenkins), Frans Hendriks, Angel Pons, Werner Zeh, Patrick Rudolph, Wim Vervoorn,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42795
to look at the new patch set (#5).
Change subject: src: Remove whitespaces before tabs ......................................................................
src: Remove whitespaces before tabs
Change-Id: I73695152ec8d8ab2dabf8421ef2405f70de0f4ba Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/facebook/fbg1701/spd/KINGSTON_B5116ECMDXGGB.spd.hex M src/mainboard/facebook/fbg1701/spd/MICRON_MT41K512M16HA-125A.spd.hex M src/mainboard/facebook/fbg1701/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex M src/mainboard/portwell/m107/spd/KINGSTON_B5116ECMDXGGB.spd.hex M src/mainboard/portwell/m107/spd/MICRON_MT41K512M16HA-125A.spd.hex M src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex M src/mainboard/prodrive/hermes/devicetree.cb M src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb M src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb M src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb M src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb M src/soc/intel/cannonlake/acpi/scs.asl M src/soc/intel/common/acpi/lpit.asl M src/soc/intel/tigerlake/acpi/tcss_dma.asl M src/soc/intel/xeon_sp/cpx/acpi/uncore_irq.asl 15 files changed, 16 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/42795/5
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42795 )
Change subject: src: Remove whitespaces before tabs ......................................................................
Patch Set 5: Code-Review+2
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42795 )
Change subject: src: Remove whitespaces before tabs ......................................................................
Patch Set 5: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42795 )
Change subject: src: Remove whitespaces before tabs ......................................................................
src: Remove whitespaces before tabs
Change-Id: I73695152ec8d8ab2dabf8421ef2405f70de0f4ba Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/42795 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Frans Hendriks fhendriks@eltan.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/facebook/fbg1701/spd/KINGSTON_B5116ECMDXGGB.spd.hex M src/mainboard/facebook/fbg1701/spd/MICRON_MT41K512M16HA-125A.spd.hex M src/mainboard/facebook/fbg1701/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex M src/mainboard/portwell/m107/spd/KINGSTON_B5116ECMDXGGB.spd.hex M src/mainboard/portwell/m107/spd/MICRON_MT41K512M16HA-125A.spd.hex M src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex M src/mainboard/prodrive/hermes/devicetree.cb M src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb M src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb M src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb M src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb M src/soc/intel/cannonlake/acpi/scs.asl M src/soc/intel/common/acpi/lpit.asl M src/soc/intel/tigerlake/acpi/tcss_dma.asl M src/soc/intel/xeon_sp/cpx/acpi/uncore_irq.asl 15 files changed, 16 insertions(+), 16 deletions(-)
Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/facebook/fbg1701/spd/KINGSTON_B5116ECMDXGGB.spd.hex b/src/mainboard/facebook/fbg1701/spd/KINGSTON_B5116ECMDXGGB.spd.hex index bce16cc..c51a5b901 100644 --- a/src/mainboard/facebook/fbg1701/spd/KINGSTON_B5116ECMDXGGB.spd.hex +++ b/src/mainboard/facebook/fbg1701/spd/KINGSTON_B5116ECMDXGGB.spd.hex @@ -170,7 +170,7 @@ 00
# 33 SDRAM device type -# byte [1:0] : 00b = Signal Loading not specified +# byte [1:0] : 00b = Signal Loading not specified # byte [6:4] : 000b = Die count not specified # byte [7] : 0 = Standard Monolithic DRAM Device 00 diff --git a/src/mainboard/facebook/fbg1701/spd/MICRON_MT41K512M16HA-125A.spd.hex b/src/mainboard/facebook/fbg1701/spd/MICRON_MT41K512M16HA-125A.spd.hex index fa55389..5007a26 100644 --- a/src/mainboard/facebook/fbg1701/spd/MICRON_MT41K512M16HA-125A.spd.hex +++ b/src/mainboard/facebook/fbg1701/spd/MICRON_MT41K512M16HA-125A.spd.hex @@ -170,7 +170,7 @@ 00
# 33 SDRAM device type -# byte [1:0] : 00b = Signal Loading not specified +# byte [1:0] : 00b = Signal Loading not specified # byte [6:4] : 000b = Die count not specified # byte [7] : 1 = Non-Standard Device 80 diff --git a/src/mainboard/facebook/fbg1701/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex b/src/mainboard/facebook/fbg1701/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex index 11ec821..c3b71d6 100644 --- a/src/mainboard/facebook/fbg1701/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex +++ b/src/mainboard/facebook/fbg1701/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex @@ -168,7 +168,7 @@
# 33 SDRAM device type # byte [1:0] : 01b = multi load stack -# byte [6:4] : 100b = 8 die +# byte [6:4] : 100b = 8 die # byte [7] : 0 = Standard Device 41
diff --git a/src/mainboard/portwell/m107/spd/KINGSTON_B5116ECMDXGGB.spd.hex b/src/mainboard/portwell/m107/spd/KINGSTON_B5116ECMDXGGB.spd.hex index bce16cc..c51a5b901 100644 --- a/src/mainboard/portwell/m107/spd/KINGSTON_B5116ECMDXGGB.spd.hex +++ b/src/mainboard/portwell/m107/spd/KINGSTON_B5116ECMDXGGB.spd.hex @@ -170,7 +170,7 @@ 00
# 33 SDRAM device type -# byte [1:0] : 00b = Signal Loading not specified +# byte [1:0] : 00b = Signal Loading not specified # byte [6:4] : 000b = Die count not specified # byte [7] : 0 = Standard Monolithic DRAM Device 00 diff --git a/src/mainboard/portwell/m107/spd/MICRON_MT41K512M16HA-125A.spd.hex b/src/mainboard/portwell/m107/spd/MICRON_MT41K512M16HA-125A.spd.hex index fa55389..5007a26 100644 --- a/src/mainboard/portwell/m107/spd/MICRON_MT41K512M16HA-125A.spd.hex +++ b/src/mainboard/portwell/m107/spd/MICRON_MT41K512M16HA-125A.spd.hex @@ -170,7 +170,7 @@ 00
# 33 SDRAM device type -# byte [1:0] : 00b = Signal Loading not specified +# byte [1:0] : 00b = Signal Loading not specified # byte [6:4] : 000b = Die count not specified # byte [7] : 1 = Non-Standard Device 80 diff --git a/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex b/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex index 11ec821..c3b71d6 100644 --- a/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex +++ b/src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex @@ -168,7 +168,7 @@
# 33 SDRAM device type # byte [1:0] : 01b = multi load stack -# byte [6:4] : 100b = 8 die +# byte [6:4] : 100b = 8 die # byte [7] : 0 = Standard Device 41
diff --git a/src/mainboard/prodrive/hermes/devicetree.cb b/src/mainboard/prodrive/hermes/devicetree.cb index c55ac92..532254b 100644 --- a/src/mainboard/prodrive/hermes/devicetree.cb +++ b/src/mainboard/prodrive/hermes/devicetree.cb @@ -34,7 +34,7 @@ device pci 00.0 on end # Aspeed 2500 VGA end end # PCIe - device pci 1f.0 on # LPC Interface + device pci 1f.0 on # LPC Interface chip drivers/pc80/tpm device pnp 0c31.0 on end end diff --git a/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb b/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb index 93bae80..a56096e 100644 --- a/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb +++ b/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb @@ -25,7 +25,7 @@ # Enumeration starts at 0 for PCIE1 # Ports are not hotplugable register "PcieRpEnable[0]" = "1" # Slot3 x4 - # Set MaxPayload to 256 bytes + # Set MaxPayload to 256 bytes register "PcieRpMaxPayload[0]" = "RpMaxPayload_256" # Enable Latency Tolerance Reporting Mechanism register "PcieRpLtrEnable[0]" = "1" diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb index 4074bae..be50408 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb @@ -93,7 +93,7 @@ device pci 1c.0 on end # - eMMC device pci 1d.0 off end # - UFS device pci 1e.0 off end # - SDIO - device pci 1f.0 on # - LPC + device pci 1f.0 on # - LPC chip drivers/pc80/tpm device pnp 0c31.0 on end end diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb index 723ecb3..33664fe 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb @@ -108,7 +108,7 @@ device pci 1c.0 on end # - eMMC device pci 1d.0 off end # - UFS device pci 1e.0 off end # - SDIO - device pci 1f.0 on # - LPC + device pci 1f.0 on # - LPC chip drivers/pc80/tpm device pnp 0c31.0 on end end diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb index 3b52f65..a865f9f 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb @@ -72,7 +72,7 @@ device pci 1c.0 off end # - eMMC device pci 1d.0 off end # - UFS device pci 1e.0 off end # - SDIO - device pci 1f.0 on # - LPC + device pci 1f.0 on # - LPC chip drivers/pc80/tpm device pnp 0c31.0 on end end diff --git a/src/soc/intel/cannonlake/acpi/scs.asl b/src/soc/intel/cannonlake/acpi/scs.asl index ae0afc8..8e1de1e 100644 --- a/src/soc/intel/cannonlake/acpi/scs.asl +++ b/src/soc/intel/cannonlake/acpi/scs.asl @@ -82,7 +82,7 @@ * containing one bit for each function index, starting * with zero. * Bit 0 - Indicates whether there is support for any - * functions other than function 0 + * functions other than function 0 * Bit 1 - Indicates support to clear power control * register * Bit 2 - Indicates support to set power control diff --git a/src/soc/intel/common/acpi/lpit.asl b/src/soc/intel/common/acpi/lpit.asl index b81275e..348ae56 100644 --- a/src/soc/intel/common/acpi/lpit.asl +++ b/src/soc/intel/common/acpi/lpit.asl @@ -69,7 +69,7 @@ /* * Save the current PM bits then * enable GPIO PM with MISCCFG_ENABLE_GPIO_PM_CONFIG - */ + */ If (CondRefOf (_SB.PCI0.EGPM)) { _SB.PCI0.EGPM () diff --git a/src/soc/intel/tigerlake/acpi/tcss_dma.asl b/src/soc/intel/tigerlake/acpi/tcss_dma.asl index 8eab92f..3d44d92 100644 --- a/src/soc/intel/tigerlake/acpi/tcss_dma.asl +++ b/src/soc/intel/tigerlake/acpi/tcss_dma.asl @@ -56,7 +56,7 @@ */ Method (D3CX, 0, Serialized) { - DD3E = 0 /* Disable DMA RTD3 */ + DD3E = 0 /* Disable DMA RTD3 */ STAT = 0x1 }
@@ -65,7 +65,7 @@ */ Method (D3CE, 0, Serialized) { - DD3E = 1 /* Enable DMA RTD3 */ + DD3E = 1 /* Enable DMA RTD3 */ STAT = 0 }
diff --git a/src/soc/intel/xeon_sp/cpx/acpi/uncore_irq.asl b/src/soc/intel/xeon_sp/cpx/acpi/uncore_irq.asl index d83bf26..0505152 100644 --- a/src/soc/intel/xeon_sp/cpx/acpi/uncore_irq.asl +++ b/src/soc/intel/xeon_sp/cpx/acpi/uncore_irq.asl @@ -6,7 +6,7 @@ * The mapping fields ae Address, Pin, Source, Source Index. */
-#define GEN_PCIE_LEGACY_IRQ() \ +#define GEN_PCIE_LEGACY_IRQ() \ Package () { 0x0000FFFF, 0x00, LNKA, 0x00 }, \ Package () { 0x0001FFFF, 0x01, LNKB, 0x00 }, \ Package () { 0x0002FFFF, 0x02, LNKC, 0x00 }, \
-
Angel Pons (Code Review) -
Frans Hendriks (Code Review)
-
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Werner Zeh (Code Review)
-
Wim Vervoorn (Code Review)