Attention is currently required from: Hung-Te Lin, Knox Chiou, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85666?usp=email )
Change subject: mb/google/rauru: Implement SKU ID
......................................................................
Patch Set 10:
(2 comments)
File src/mainboard/google/rauru/boardid.c:
https://review.coreboot.org/c/coreboot/+/85666/comment/ffaa1745_392904c8?usp... :
PS9, Line 65:
If the definition starts getting that complicated, I'd suggest using `DEFINE_BITFIELD` API: […]
Done
https://review.coreboot.org/c/coreboot/+/85666/comment/fd8195b3_2503baec?usp... :
PS9, Line 77: 8
Shouldn't this be 9 if bit[11:9] is for storage id?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85666?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I49ba6f428f55d3aae1b84a4d5ce06bec765caece
Gerrit-Change-Number: 85666
Gerrit-PatchSet: 10
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Knox Chiou
knoxchiou@google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Knox Chiou
knoxchiou@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Sun, 22 Dec 2024 12:02:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com