Change in coreboot[master]: mb/google/guybrush/var/dewatt: Override EN_SPKR GPIO_70 - coreboot-gerrit

9 Dec 2021


      Attention is currently required from: Paul Menzel, Kenneth Chan.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59978 )
Change subject: mb/google/guybrush/var/dewatt: Override EN_SPKR GPIO_70
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/guybrush/variants/dewatt/gpio.c:
https://review.coreboot.org/c/coreboot/+/59978/comment/2d468a37_e69c2e58 
PS4, Line 11: 	PAD_GPO(GPIO_70, HIGH),
GPIO_70 is HIGH in base_gpio_table. Why does it need to be overridden?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59978
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf705e12f30ad145449be8d97cb214c56c02ec33
Gerrit-Change-Number: 59978
Gerrit-PatchSet: 4
Gerrit-Owner: Kenneth Chan kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Bhanu Prakash Maiya bhanumaiya@google.com
Gerrit-Reviewer: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Kenneth Chan kenneth.chan@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 09 Dec 2021 04:22:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment