Attention is currently required from: Karthik Ramasubramanian, Shelley Chen.
Kun Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81817?usp=email )
Change subject: mb/google/brox: Create lotso variant
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/brox/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/81817/comment/9c8ff447_1cf0f5d6 :
PS3, Line 13: select BOARD_GOOGLE_BA
Move this out of this file and add as: […]
Done
File src/mainboard/google/brox/variants/lotso/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/81817/comment/94ef7fe6_38b8f5fc :
PS3, Line 1: bootblock-y += gpio.c
Please add SPDX License Identifier for the makefile. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81817?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5939127f9e6abe5b792c0627d9d67e739b27083b
Gerrit-Change-Number: 81817
Gerrit-PatchSet: 4
Gerrit-Owner: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 16 Apr 2024 02:04:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment