Patch set updated for coreboot: 4a47865 superio/smscsuperio: Fix chip detection

[Kyösti Mälkki]

Kyösti Mälkki ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5949

-gerrit

commit 4a478658e661ef2094b920736208acabfc6f572d
Author: Kyösti Mälkki 
Date:   Fri Jun 6 21:46:47 2014 +0300

superio/smscsuperio: Fix chip detection

There was dereference of NULL dev->ops in pnp_enter/exit_conf_mode()
    as those calls were made before pnp_enable_devices() was run.
    Since hardware did not enter configuration mode, detection failed with
    ID and REV read as 0xff.

Change-Id: If13086707cd86e392890ccf4f717e13a87f3317f
    Signed-off-by: Kyösti Mälkki 
---
 src/superio/smsc/smscsuperio/superio.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/superio/smsc/smscsuperio/superio.c b/src/superio/smsc/smscsuperio/superio.c
index 0d62a9a..92cae86 100644
--- a/src/superio/smsc/smscsuperio/superio.c
+++ b/src/superio/smsc/smscsuperio/superio.c
@@ -231,11 +231,12 @@ static void enable_dev(device_t dev)
    u8 test7;

if (first_time) {
+
+		pnp_enter_conf_mode_55(dev);
+
    	/* Read the device ID and revision of the Super I/O chip. */
-		pnp_enter_conf_mode(dev);
    	superio_id = pnp_read_config(dev, DEVICE_ID_REG);
    	superio_rev = pnp_read_config(dev, DEVICE_REV_REG);
-		pnp_exit_conf_mode(dev);

/* TODO: Error handling? */

@@ -257,6 +258,8 @@ static void enable_dev(device_t dev)
    		test7 |= (1 << 0);
    		pnp_write_config(dev, DEVICE_TEST7_REG, test7);
    	}
+
+		pnp_exit_conf_mode_aa(dev);
    }

/* Find the correct Super I/O. */