Change in coreboot[master]: WIP: tpm: Refactor Kconfig

[Werner Zeh (Code Review)]

Attention is currently required from: Stefan Ott, Felix Singer, Patrick Rudolph, Frans Hendriks, Jonathan Zhang, Tristan Corrick, Jeremy Soller, Nick Vaccaro, Angel Pons, Julius Werner, Arthur Heymans, Andrey Petrov, Piotr Król, Jes Klinke, Tim Crawford, Nico Huber, Sean Rhodes, Michał Żygowski, Maxim Polyakov, Johnny Lin, Christian Walter, Tim Wawrzynczak, Alexander Couzens, Tim Chu.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63424 )

Change subject: WIP: tpm: Refactor Kconfig
......................................................................

Patch Set 3: Code-Review+1

(3 comments)

File src/drivers/i2c/tpm/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/63424/comment/fccf9b07_59891627 
PS3, Line 9: ifeq ($(CONFIG_TPM_ATMEL),y)
           : ramstage-y += tis_atmel.c
           : romstage-y += tis_atmel.c
           : verstage-y += tis_atmel.c
           : bootblock-y += tis_atmel.c
           : postcar-y += tis_atmel.c
           : elif ($(CONFIG_TPM_GOOGLE),y)
           : ramstage-y += cr50.c
           : romstage-y += cr50.c
           : verstage-y += cr50.c
           : bootblock-y += cr50.c
           : postcar-y += cr50.c
           : else
           : ramstage-y += tpm.c
           : romstage-y += tpm.c
           : verstage-y += tpm.c
           : bootblock-y += tpm.c
           : postcar-y += tpm.c
           : endif
You could use the 'all-y' target here as you add the driver to every stage anyway.
And once you are touching it it could be used for tis.c as well.

File src/drivers/pc80/tpm/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/63424/comment/1fbc1fcb_ac8077f6 
PS3, Line 1: bootblock-$(CONFIG_LPC_TPM) += tis.c
           : verstage-$(CONFIG_LPC_TPM) += tis.c
           : romstage-$(CONFIG_LPC_TPM) += tis.c
           : ramstage-$(CONFIG_LPC_TPM) += tis.c
           : postcar-$(CONFIG_LPC_TPM) += tis.c
all-$(CONFIG_LPC_TPM) += tis.c
But could be done in a follow-up.

File src/soc/intel/common/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/63424/comment/e5baf8e0_8ed5f510 
PS3, Line 23: bootblock-$(CONFIG_TPM_GOOGLE) += tpm_tis.c
            : verstage-$(CONFIG_TPM_GOOGLE) += tpm_tis.c
            : romstage-$(CONFIG_TPM_GOOGLE) += tpm_tis.c
            : ramstage-$(CONFIG_TPM_GOOGLE) += tpm_tis.c
            : postcar-$(CONFIG_TPM_GOOGLE) += tpm_tis.c
all-$(CONFIG_TPM_GOOGLE)