Attention is currently required from: Alexander Couzens, Evgeny Zinoviev, Felix Held, Felix Singer, Jeremy Soller, Jonathon Hall, Matt DeVillier, Michael Niewöhner, Michał Żygowski, Philipp Hug, Piotr Król, Ron Minnich, Sean Rhodes, Tim Crawford.
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb: source site-local mainboard Kconfig.name and Kconfig files
......................................................................
Why is symlinking a problem now? Or in other words, why doesn't that work anymore?
I don't think we allow symlinks to be checked into the coreboot repo, though I do see some in submodule repos. It's probably also good to have the repo clone-able in environments such as Windows where symlinks don't work at all (AFAIK).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83119?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4106fea7197c979e6648ebbbbaa107070c916727
Gerrit-Change-Number: 83119
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Evgeny Zinoviev
me@ch1p.io
Gerrit-Attention: Ron Minnich
rminnich@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 04 Jul 2024 23:41:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Jonathon Hall
jonathon.hall@puri.sm
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de