Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Martin L Roth, Paul Menzel.
Wonkyu Kim has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84107?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: payloads/depthcharge: Add default 64-bit libpayload config
......................................................................
Patch Set 6:
(1 comment)
File payloads/libpayload/configs/defconfig_64:
https://review.coreboot.org/c/coreboot/+/84107/comment/e659e816_35e988f7?usp... :
PS6, Line 1: CONFIG_LP_CHROMEOS=y
Do we need this config?
defconfig does not have this.
I think we need to just add "CONFIG_LP_ARCH_X86_64=y" on top of existing defconfig.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84107?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iac07cf9e3c11e49955c69553407be76ef4f8c060
Gerrit-Change-Number: 84107
Gerrit-PatchSet: 6
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 30 Aug 2024 10:14:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No