Change in ...coreboot[master]: nb/i945/stage_cache.c: Drop unnecessary include

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

HAOUAS Elyes (Code Review)

5 Mar 2019 5 Mar '19

2:12 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31714

Change subject: nb/i945/stage_cache.c: Drop unnecessary include ......................................................................

nb/i945/stage_cache.c: Drop unnecessary include

Change-Id: If6224c28012241e4925e05e14f0499857054f178 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/stage_cache.c 1 file changed, 1 insertion(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/31714/1

diff --git a/src/northbridge/intel/i945/stage_cache.c b/src/northbridge/intel/i945/stage_cache.c index 26d4e7e..47f08c1 100644 --- a/src/northbridge/intel/i945/stage_cache.c +++ b/src/northbridge/intel/i945/stage_cache.c @@ -13,12 +13,9 @@ * GNU General Public License for more details. */

-#include <arch/io.h> -#include <cbmem.h> -#include <device/pci.h> +#include <stdint.h> #include <stage_cache.h> #include <cpu/intel/smm/gen1/smi.h> -#include "i945.h"

void stage_cache_external_region(void **base, size_t *size) {

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

HAOUAS Elyes (Code Review)

5 Mar 5 Mar

2:15 a.m.

Hello Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31714

to look at the new patch set (#2).

Change subject: nb/i945/stage_cache.c: Drop unnecessary include ......................................................................

nb/i945/stage_cache.c: Drop unnecessary include

Change-Id: If6224c28012241e4925e05e14f0499857054f178 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/stage_cache.c 1 file changed, 1 insertion(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/31714/2

Kyösti Mälkki (Code Review)

2:17 a.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31714 )

Change subject: nb/i945/stage_cache.c: Drop unnecessary include ......................................................................

Patch Set 2: Code-Review+1

Pull fresh master and rebase manually.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If6224c28012241e4925e05e14f0499857054f178 Gerrit-Change-Number: 31714 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 04 Mar 2019 15:17:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

2:20 a.m.

New subject: Change in ...coreboot[master]: nb/{gm45i945,pineview,x4x}/stage_cache.c: Drop unnecessary include

Hello Kyösti Mälkki, Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31714

to look at the new patch set (#3).

Change subject: nb/{gm45i945,pineview,x4x}/stage_cache.c: Drop unnecessary include ......................................................................

nb/{gm45i945,pineview,x4x}/stage_cache.c: Drop unnecessary include

Change-Id: If6224c28012241e4925e05e14f0499857054f178 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/gm45/stage_cache.c M src/northbridge/intel/i945/stage_cache.c M src/northbridge/intel/pineview/stage_cache.c M src/northbridge/intel/x4x/stage_cache.c 4 files changed, 4 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/31714/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/31714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If6224c28012241e4925e05e14f0499857054f178 Gerrit-Change-Number: 31714 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

2:31 a.m.

New subject: Change in ...coreboot[master]: nb/{gm45i945,pineview,x4x}/stage_cache.c: Drop unnecessary includes

Hello Kyösti Mälkki, Patrick Rudolph, build bot (Jenkins), Damien Zammit,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31714

to look at the new patch set (#4).

Change subject: nb/{gm45i945,pineview,x4x}/stage_cache.c: Drop unnecessary includes ......................................................................

nb/{gm45i945,pineview,x4x}/stage_cache.c: Drop unnecessary includes

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/31714/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/31714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If6224c28012241e4925e05e14f0499857054f178 Gerrit-Change-Number: 31714 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Damien Zammit damien@zamaudio.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Kyösti Mälkki (Code Review)

3:09 a.m.

New subject: Change in ...coreboot[master]: nb/{gm45i945,pineview,x4x}/stage_cache.c: Drop unnecessary includes

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31714 )

Change subject: nb/{gm45i945,pineview,x4x}/stage_cache.c: Drop unnecessary includes ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/31714/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31714/4//COMMIT_MSG@7 PS4, Line 7: nb/{gm45i945,pineview,x4x}/stage_cache.c: Drop unnecessary includes nb/intel/stage_cache.c: Drop ...

-- To view, visit https://review.coreboot.org/c/coreboot/+/31714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If6224c28012241e4925e05e14f0499857054f178 Gerrit-Change-Number: 31714 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Damien Zammit damien@zamaudio.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 04 Mar 2019 16:09:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

13 Mar 13 Mar

3:23 p.m.

New subject: Change in ...coreboot[master]: nb/intel/stage_cache.c: Drop unnecessary includes

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31714 )

Change subject: nb/intel/stage_cache.c: Drop unnecessary includes ......................................................................

Patch Set 6: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If6224c28012241e4925e05e14f0499857054f178 Gerrit-Change-Number: 31714 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Damien Zammit damien@zamaudio.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 13 Mar 2019 04:23:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

3:23 p.m.

New subject: Change in ...coreboot[master]: nb/intel/stage_cache.c: Drop unnecessary includes

Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31714 )

Change subject: nb/intel/stage_cache.c: Drop unnecessary includes ......................................................................

nb/intel/stage_cache.c: Drop unnecessary includes

Change-Id: If6224c28012241e4925e05e14f0499857054f178 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/31714 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/northbridge/intel/gm45/stage_cache.c M src/northbridge/intel/i945/stage_cache.c M src/northbridge/intel/pineview/stage_cache.c M src/northbridge/intel/x4x/stage_cache.c 4 files changed, 4 insertions(+), 12 deletions(-)

Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved

diff --git a/src/northbridge/intel/gm45/stage_cache.c b/src/northbridge/intel/gm45/stage_cache.c index cbe4556..47f08c1 100644 --- a/src/northbridge/intel/gm45/stage_cache.c +++ b/src/northbridge/intel/gm45/stage_cache.c @@ -13,11 +13,9 @@ * GNU General Public License for more details. */

-#include <cbmem.h> -#include <device/pci.h> +#include <stdint.h> #include <stage_cache.h> #include <cpu/intel/smm/gen1/smi.h> -#include "gm45.h"

void stage_cache_external_region(void **base, size_t *size) { diff --git a/src/northbridge/intel/i945/stage_cache.c b/src/northbridge/intel/i945/stage_cache.c index b659796..47f08c1 100644 --- a/src/northbridge/intel/i945/stage_cache.c +++ b/src/northbridge/intel/i945/stage_cache.c @@ -13,11 +13,9 @@ * GNU General Public License for more details. */

-#include <cbmem.h> -#include <device/pci.h> +#include <stdint.h> #include <stage_cache.h> #include <cpu/intel/smm/gen1/smi.h> -#include "i945.h"

void stage_cache_external_region(void **base, size_t *size) { diff --git a/src/northbridge/intel/pineview/stage_cache.c b/src/northbridge/intel/pineview/stage_cache.c index 6f949e6..47f08c1 100644 --- a/src/northbridge/intel/pineview/stage_cache.c +++ b/src/northbridge/intel/pineview/stage_cache.c @@ -13,11 +13,9 @@ * GNU General Public License for more details. */

-#include <cbmem.h> -#include <device/pci.h> +#include <stdint.h> #include <stage_cache.h> #include <cpu/intel/smm/gen1/smi.h> -#include "pineview.h"

void stage_cache_external_region(void **base, size_t *size) { diff --git a/src/northbridge/intel/x4x/stage_cache.c b/src/northbridge/intel/x4x/stage_cache.c index 8862c61..47f08c1 100644 --- a/src/northbridge/intel/x4x/stage_cache.c +++ b/src/northbridge/intel/x4x/stage_cache.c @@ -13,11 +13,9 @@ * GNU General Public License for more details. */

-#include <cbmem.h> -#include <device/pci.h> +#include <stdint.h> #include <stage_cache.h> #include <cpu/intel/smm/gen1/smi.h> -#include "x4x.h"

void stage_cache_external_region(void **base, size_t *size) {

-- To view, visit https://review.coreboot.org/c/coreboot/+/31714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If6224c28012241e4925e05e14f0499857054f178 Gerrit-Change-Number: 31714 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Damien Zammit damien@zamaudio.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

2035

days inactive

2044

days old

coreboot-gerrit@coreboot.org

7 comments

2 participants

tags (0)

participants (2)

HAOUAS Elyes (Code Review)
Kyösti Mälkki (Code Review)