Attention is currently required from: Bora Guvendik, Cliff Huang, Jérémy Compostella, Kapil Porwal, Pranava Y N, Ravishankar Sarawadi, Subrata Banik.
Saurabh Mishra has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83635?usp=email )
Change subject: soc/intel/ptl: Do initial Panther Lake SoC commit till romstage
......................................................................
Patch Set 76:
(3 comments)
File src/soc/intel/pantherlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/83635/comment/ab2a0f5d_067c7e7b?usp... :
PS75, Line 49: PTL-H 12Xe (25W) SoC.
wrap up text > 96 char per line. […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/83635/comment/7118de96_71c904d3?usp... :
PS75, Line 59: U/
should remove `U`
Acknowledged
File src/soc/intel/pantherlake/chip.h:
https://review.coreboot.org/c/coreboot/+/83635/comment/0137fc2b_6f9354e4?usp... :
PS74, Line 162: enum {
: IGD_SM_0MB = 0x00,
: IGD_SM_32MB = 0x01,
: IGD_SM_64MB = 0x02,
: IGD_SM_96MB = 0x03,
: IGD_SM_128MB = 0x04,
: IGD_SM_160MB = 0x05,
: IGD_SM_4MB = 0xF0,
: IGD_SM_8MB = 0xF1,
: IGD_SM_12MB = 0xF2,
: IGD_SM_16MB = 0xF3,
: IGD_SM_20MB = 0xF4,
: IGD_SM_24MB = 0xF5,
: IGD_SM_28MB = 0xF6,
: IGD_SM_36MB = 0xF8,
: IGD_SM_40MB = 0xF9,
: IGD_SM_44MB = 0xFA,
: IGD_SM_48MB = 0xFB,
: IGD_SM_52MB = 0xFC,
: IGD_SM_56MB = 0xFD,
: IGD_SM_60MB = 0xFE,
: } IgdDvmt50PreAlloc;
Hi Subrata, we are using these macro to set IGD stolen size in romstage. […]
Hi Subrata, sure, i have updated the enum values, matched with FSP, all are same except IGD_SM_128MB. Updated accordingly.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83635?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I27e1a6c56bca01e7f5f53fbf3cb6855bac7b2848
Gerrit-Change-Number: 83635
Gerrit-PatchSet: 76
Gerrit-Owner: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-CC: Appukuttan V K
appukuttan.vk@intel.com
Gerrit-CC: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Cliff Huang
cliff.huang@intel.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-CC: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-CC: Sanju Jose Thottan
sanjujose.thottan@intel.com
Gerrit-CC: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-CC: Vikrant L Jadeja
vikrant.l.jadeja@intel.com
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Wed, 14 Aug 2024 12:50:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Saurabh Mishra
mishra.saurabh@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com