Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69340 )
(
2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/brya/var/agah: Set GPP_H13 to reset on PLTRST ......................................................................
mb/google/brya/var/agah: Set GPP_H13 to reset on PLTRST
GPP_H13 should be reset when going to S5. Update it to do so on PLTRST
BUG=b:240617195 TEST=Measured on Agah that PP3300_SD_X goes off in S5.
Change-Id: I959f92f2c486e0ca5cb4269b271c163b4c4925d4 Signed-off-by: Tarun Tuli taruntuli@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/69340 Reviewed-by: Subrata Banik subratabanik@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/brya/variants/agah/gpio.c 1 file changed, 21 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved
diff --git a/src/mainboard/google/brya/variants/agah/gpio.c b/src/mainboard/google/brya/variants/agah/gpio.c index b496843..02ed698 100644 --- a/src/mainboard/google/brya/variants/agah/gpio.c +++ b/src/mainboard/google/brya/variants/agah/gpio.c @@ -132,7 +132,7 @@ /* H9 : I2C4_SCL ==> NC */ PAD_NC(GPP_H9, NONE), /* H13 : I2C7_SCL ==> EN_PP3300_SD */ - PAD_CFG_GPO(GPP_H13, 1, DEEP), + PAD_CFG_GPO(GPP_H13, 1, PLTRST), /* H19 : SRCCLKREQ4# ==> LAN_CLKREQ_ODL */ PAD_CFG_NF(GPP_H19, NONE, DEEP, NF1), /* H21 : IMGCLKOUT2 ==> NC */ @@ -190,7 +190,7 @@ * then deassert PERST# in romstage */ /* H13 : I2C7_SCL ==> EN_PP3300_SD */ - PAD_CFG_GPO(GPP_H13, 1, DEEP), + PAD_CFG_GPO(GPP_H13, 1, PLTRST), /* B4 : PROC_GP3 ==> SSD_PERST_L */ PAD_CFG_GPO(GPP_B4, 0, DEEP),