Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Eric Lai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik.
Amanda Hwang has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/83155?usp=email )
Change subject: mb/google/trulo/var/orisa: Fill in gpio.h
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/brya/variants/orisa/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/83155/comment/6a245ee6_aed014e9?usp... :
PS6, Line 12: GPE0_DW2_17
I am not sure where is the pmc_gpe0_dw2 declared? Could you help to check it?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83155?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9de842a8a66632314d5fdf6444005d34338a1100
Gerrit-Change-Number: 83155
Gerrit-PatchSet: 7
Gerrit-Owner: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 24 Jun 2024 06:41:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com