[S] Change in coreboot[master]: mb/google/myst: Update PCIe romstage gpios - coreboot-gerrit

13 Jun 2023


      Attention is currently required from: Eric Lai, Felix Held, Karthik Ramasubramanian, Martin Roth, Tim Van Patten.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75699?usp=email )
Change subject: mb/google/myst: Update PCIe romstage gpios
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/myst/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/75699/comment/5388ab7f_b7ee12e7 :
PS3, Line 199: /* PCIE_RST0_L */
             : 	PAD_NFO(GPIO_26, PCIE_RST0_L, HIGH),
...
i'd move deaserting the main reset line to the end of the table so that it'll be done as the last st […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/75699?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24ad6c1addedb414afade2512b6628022d000a47
Gerrit-Change-Number: 75699
Gerrit-PatchSet: 4
Gerrit-Owner: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Tim Van Patten timvp@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-Attention: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 13 Jun 2023 14:57:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment