Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Sumeet R Pawnikar has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83565?usp=email )
Change subject: mb/google/brya/var/trulo: Add Thermal descriptions
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83565/comment/3a7c75dc_3be8af84?usp... :
PS1, Line 12: BUG=b:351976770
Add me in bug to understand the background of this change. Thanks.
File src/mainboard/google/brya/variants/trulo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83565/comment/45f312ed_e2c5c2e0?usp... :
PS1, Line 198: register "policies.active" = "{
We need different setting values to control Fan speed for 6W and 15W design, if 6W system has Fan.
Is 6W design Fan based the system?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83565?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I32f9219c0ba6b70f847f0752bff8aa2e4fdd0979
Gerrit-Change-Number: 83565
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 19 Jul 2024 05:23:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No