Attention is currently required from: Daisuke Nojiri. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61383 )
Change subject: mb/google/brya/var/redrix: Enable MKBP wake ......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/brya/variants/redrix/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/61383/comment/b4f296ad_3b61c53b PS2, Line 14: EC_HOST_EVENT_USB_MUX We should ensure that all brya devices have the same policies on wake (modulo exceptions like PCHG). Right now we have this as an S0ix-only wake in the brya baseboard, so this should probably be taken out here, and if the baseboard needs to be updated, then update it there.
https://review.coreboot.org/c/coreboot/+/61383/comment/ab5f026c_59271803 PS2, Line 21: EC_HOST_EVENT_MKBP nit: this is redundant, it's already contained in `MAINBOARD_EC_S3_WAKE_EVENTS`