Attention is currently required from: Maximilian Brune.
Elyes Haouas has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83617?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: util/cbfstool/cbfs-payload-linux: Add error handling
......................................................................
Patch Set 1:
(1 comment)
File util/cbfstool/cbfs-payload-linux.c:
https://review.coreboot.org/c/coreboot/+/83617/comment/266e8b25_9f867297?usp... :
PS1, Line 142: uint32_t type, uint64_t load_addr,
`code indent should use tabs where possible`
Please fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83617?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie36ad469c73cb3ff9360acc9bbe66c245e8b4a1e
Gerrit-Change-Number: 83617
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Comment-Date: Fri, 16 Aug 2024 19:30:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No