Attention is currently required from: Maulik V Vaghela, Paul Menzel, Tim Wawrzynczak.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56882 )
Change subject: mb/google/brya: Configure EN_FCAM_PWR to high
......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56882/comment/d0d42359_d34b6fd2
PS3, Line 7: Configure A17 GPIO to high
Use 3. […]
Done
https://review.coreboot.org/c/coreboot/+/56882/comment/526c4337_413d14bf
PS3, Line 9: Recent change https://review.coreboot.org/c/coreboot/+/56655
As it’s merged already, please reference the commit hash and summary.
Done
https://review.coreboot.org/c/coreboot/+/56882/comment/506fd69e_980a093e
PS3, Line 11: probing, however
probing. […]
Done
https://review.coreboot.org/c/coreboot/+/56882/comment/7ff127c9_73349351
PS3, Line 12: by A17, this caused USB UFC enumeration to fail
Please add dot/period at the end of sentences.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56882
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88c204ec07b1f7511f0d88074e336cfc9116a7d2
Gerrit-Change-Number: 56882
Gerrit-PatchSet: 4
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sanju Jose Thottan
sanjujose.thottan@intel.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Comment-Date: Fri, 13 Aug 2021 09:43:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment