[M] Change in coreboot[main]: lib/string: Add strncat() and strcat() functions - coreboot-gerrit

5 Aug 2024


      Attention is currently required from: Jakub Czapiga.
Yu-Ping Wu has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83765?usp=email )
Change subject: lib/string: Add strncat() and strcat() functions
......................................................................
Patch Set 3:
(1 comment)
File tests/lib/string-test.c:
https://review.coreboot.org/c/coreboot/+/83765/comment/cac3957b_dc463eb3?usp... :
PS2, Line 193: ret = strncat(dst, src, len - 1);
...
`len` is the size of `str` not `src`. […]
Done. Thanks for pointing out this bug. I believe `test_strcat` doesn't have the same problem.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83765?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If02fce0eafb4f6fa01d8bab17d87a32360f4ac83
Gerrit-Change-Number: 83765
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: Jakub Czapiga czapiga@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jakub Czapiga czapiga@google.com
Gerrit-Comment-Date: Mon, 05 Aug 2024 15:20:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga czapiga@google.com